verify_rescue_musig added to EddsaSignature #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious: What doers this do? |
|
This is a backport from zksync for MuSig with Rescue as a hash function, but it doesn't look proper yet. In any case, this is work of our summer interns and will be reviewed. |
- Remove unnecessary returns
- Remove .clone() on Copy types
- Remove boolean comparisons (if flag == true -> if flag)
- Use .is_empty() instead of comparing .len() to 0
- Use augmented assignments when possible
- Struct { x: x } -> Struct { x }
- .map(|x| f(x)) -> .map(f)
- .map(|x| x.clone()) -> .cloned()
- .map(|x| *x) -> .copied()
- .iter().cloned().collect::<Vec<_>>() -> .to_vec()
- Other minor improvements
…ranklin-crypto into plonk_gadgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rescue musig verification that adds constraints to the constraint system and a test that shows that it works properly.
Also I added some utilities without which the verification algorithm wouldn't work,