Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer for boolean #30

Open
wants to merge 34 commits into
base: dev
Choose a base branch
from
Open

optimizer for boolean #30

wants to merge 34 commits into from

Conversation

Fitznik
Copy link

@Fitznik Fitznik commented Feb 2, 2022

The structure of the BooleanWrapper is created. Added storage. The tests are correct. Optimization is successful.

@shamatar
Copy link
Member

shamatar commented Feb 3, 2022

Please move this work to VM directly and do at least the following changes:

  • remove a global state. Currently if during execution of the same program in two different circuits the same variable will be boolean then it would mix them
  • do not implement equality and such things for Boolean. Use wrapper type for it. And we already have such equality in VM
  • do not use String for operation type. Use enum instead
  • add function for long-ors and long-ands, when there are chains like a | b | c | d, and we have a | b already memoized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants