[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

ayusht2810 · 2024-01-17T12:09:11Z

Summary

Added a feature to restrict bot messages to private channels and DM/GMs through plugin config.
Added a feature to restrict bot messages to a particular channel via the slash command.
Added a feature to list all channel preferences.

Ticket Link

#79

Screenshots

What to test?

Restricting bot posting meeting links in the channels when changing settings through plugin config or through slash commands.
View list of channels with updated preferences.
Disabling of settings slash command when posting meeting links is restricted.

…channels and DM/GMs

codecov · 2024-01-17T12:11:54Z

Codecov Report

Attention: Patch coverage is 41.22807% with 134 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (d73eafa) to head (2549a1e).
Report is 8 commits behind head on master.

❗ Current head 2549a1e differs from pull request most recent head 5ff77f7

Please upload reports for the commit 5ff77f7 to get more accurate results.

Files	Patch %	Lines
server/command.go	9.90%	100 Missing ⚠️
server/http.go	76.82%	15 Missing and 4 partials ⚠️
server/store.go	57.14%	12 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   18.04%   16.56%   -1.49%     
==========================================
  Files           9        9              
  Lines        1546     1733     +187     
==========================================
+ Hits          279      287       +8     
- Misses       1216     1407     +191     
+ Partials       51       39      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md

plugin.json

server/command.go

server/http.go

…ition

README.md

plugin.json

raghavaggarwal2308

Can you add testcases for this new feature

server/http.go

raghavaggarwal2308 · 2024-02-26T14:18:41Z

@ayusht2810 Please resolve conflicts

… into MM-133

raghavaggarwal2308 · 2024-03-01T12:10:18Z

@mickmister Gentle reminder for review

… into MM-133

ayusht2810 · 2024-05-02T08:07:54Z

@mickmister Gentle reminder to review the PR

mickmister

LGTM 👍 just some non-blocking comments for discussion

For the markdown table in the channel-settings list response, we should probably have it say:

Default: Allow meetings in public channels, private channels, and DMs/GMs

or

Default: Allow meetings only in private channels and DMs/GMs

then simply omit any rows from the table that have the "default" value. We could probably just remove that channel from the saved settings map if the user chooses "default". 0/5 on this though

webapp/src/actions/index.js

mickmister · 2024-05-13T18:03:07Z

server/command.go

@@ -253,6 +271,10 @@ func (p *Plugin) runDisconnectCommand(user *model.User) (string, error) {
 // runHelpCommand runs command to display help text.
 func (p *Plugin) runHelpCommand(user *model.User) (string, error) {
 	text := starterText + strings.ReplaceAll(helpText+"\n"+settingHelpText, "|", "`")
+	if p.API.HasPermissionTo(user.Id, model.PermissionManageSystem) {


Nit to use p.client instead of p.API. I wonder if we can make a golint rule for this. It doesn't make a huge difference, but it helps with references to AppError and error to avoid weird concrete vs interface things there. This HasPermissionTo method returns only a boolean so it's not any difference here

We can make a seperate for adding golint rule for not using p.API since it will include a lot changes through the code once the new lint rule is implemented

server/command.go

mickmister · 2024-05-13T18:20:13Z

server/http.go

+	}
+
+	zoomChannelSettingsMapValue := ZoomChannelSettingsMapValue{
+		ChannelName: submitRequest.CallbackId,


We're using the display name so probably best to put that here. A little unfortunate that this will become stale if the channel's display name changes. Maybe we should use channel.Name instead, which is generally more permanent? The user can change both values, but it's more likely that a display name gets changed. Storing it with the channel id below makes sense. I would expect the channel id to be in the struct as well, but it's obviously not required since the feature currently works without that

Suggested change

ChannelName: submitRequest.CallbackId,

ChannelDisplayName: submitRequest.CallbackId,

server/http.go

mickmister · 2024-05-13T18:25:05Z

server/http.go

@@ -915,3 +984,45 @@ func (p *Plugin) slackAttachmentToUpdatePMI(currentValue, channelID string) *mod

 	return &slackAttachment
 }
+
+func (p *Plugin) checkChannelPreference(channelID string) (bool, int, error) {


Suggested change

func (p *Plugin) checkChannelPreference(channelID string) (bool, int, error) {

func (p *Plugin) isChannelRestrictedForMeetings(channelID string) (bool, int, error) {

Not sure why we need the http status code to be returned from here?

Returning statusCode for any error that arises so we can return the respective error.

Right but the only values returned are http.StatusInternalServerError and http.StatusOK, which can instead be inferred by the caller if an error happened or not

server/http.go

server/store.go

Kshitij-Katiyar · 2024-06-06T12:53:11Z

LGTM 👍 just some non-blocking comments for discussion

For the markdown table in the channel-settings list response, we should probably have it say:
Default: Allow meetings in public channels, private channels, and DMs/GMs
or
Default: Allow meetings only in private channels and DMs/GMs
then simply omit any rows from the table that have the "default" value. We could probably just remove that channel from the saved settings map if the user chooses "default". 0/5 on this though

@mickmister
the default setting has a dynamic value (i.e. it can be updated in plugin configuration)

Didn't get you on this, please explain.

mickmister · 2024-06-06T15:53:45Z

@mickmister the default setting has a dynamic value (i.e. it can be updated in plugin configuration) Didn't get you on this, please explain.

@Kshitij-Katiyar Yes I was suggesting we display this value in the response in the wording I posted above. Just so when someone wants to inspect the settings on a channel, they can know what the default value is. Then we can omit any channels that are either unassigned or using the default value

Kshitij-Katiyar · 2024-06-11T11:04:36Z

Default: Allow meetings only in private channels and DMs/GMs

this was the existing channel setting list

And this is the updated channel setting list

@mickmister I hope this aligns with your suggestions. Please let us know if anything else is required.

raghavaggarwal2308 · 2024-07-01T10:17:12Z

@fmartingr Gentle reminder for review

fmartingr

Apologies for the delay, just a nit about the help text.

server/command.go

mickmister · 2024-06-19T05:04:14Z

server/http.go

@@ -915,3 +984,45 @@ func (p *Plugin) slackAttachmentToUpdatePMI(currentValue, channelID string) *mod

 	return &slackAttachment
 }
+
+func (p *Plugin) checkChannelPreference(channelID string) (bool, int, error) {


Right but the only values returned are http.StatusInternalServerError and http.StatusOK, which can instead be inferred by the caller if an error happened or not

server/configuration.go

server/command.go

… into MM-133

1. Removed unused params from function 2. Update constant name 3. Remove status code from values

raghavaggarwal2308 · 2024-07-02T18:01:22Z

@mickmister Fixed the review comments added by you

mickmister

LGTM, just one request to remove the two bin files

mickmister · 2024-07-04T06:16:04Z

bin/golangci-lint

This and bin/gotestsum should be deleted I think

@mickmister Removed

[MM-133] Work on zoom feature of restricting bot messages to private …

d3a7688

…channels and DM/GMs

ayusht2810 requested a review from mickmister as a code owner January 17, 2024 12:09

ayusht2810 self-assigned this Jan 17, 2024

ayusht2810 linked an issue Jan 17, 2024 that may be closed by this pull request

Feature request: limit posting bot message to private channels only #79

Open

ayusht2810 requested a review from raghavaggarwal2308 January 17, 2024 12:12

ayusht2810 added 3 commits January 17, 2024 17:43

[MM-133] Add role on channel-settings slash command

672f29a

[MM-133] Update readme and help text slash command on basis of user role

1fb2e67

[MM-133] Fix lint issues

0c51cfb

ayusht2810 added the 2: Dev Review Requires review by a core committer label Jan 18, 2024

[MM-133] Update dialog text

fdc98fc

raghavaggarwal2308 requested changes Jan 22, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

plugin.json Outdated Show resolved Hide resolved

raghavaggarwal2308 requested changes Jan 22, 2024

View reviewed changes

ayusht2810 and others added 2 commits January 22, 2024 23:24

[MM-133] Review fixes: Update user statements and update if else cond…

6837578

…ition

Merge branch 'master' into MM-133

ecc3cf9

raghavaggarwal2308 requested changes Feb 1, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

plugin.json Outdated Show resolved Hide resolved

plugin.json Outdated Show resolved Hide resolved

[MM-133] Update system console and some review fixes

6c05f40

raghavaggarwal2308 reviewed Feb 6, 2024

View reviewed changes

ayusht2810 added 2 commits February 7, 2024 13:28

[MM-133] Add some test cases

417a123

[MM-133] Updated a test case

fe29a06

raghavaggarwal2308 reviewed Feb 9, 2024

View reviewed changes

server/http.go Outdated Show resolved Hide resolved

raghavaggarwal2308 approved these changes Feb 26, 2024

View reviewed changes

ayusht2810 added 2 commits February 27, 2024 12:32

Merge branch 'master' of github.com:mattermost/mattermost-plugin-zoom…

645f26f

… into MM-133

[MM-133] Remove unused variable

2549a1e

Merge branch 'master' of github.com:mattermost/mattermost-plugin-zoom…

eb5981d

… into MM-133

mickmister approved these changes May 13, 2024

View reviewed changes

mickmister requested a review from AayushChaudhary0001 May 13, 2024 18:35

mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels May 13, 2024

Kshitij-Katiyar added 2 commits June 6, 2024 18:30

[MM-133]: review fixes

4c013a8

[MM-133]: fixed server testcases

ebc3bca

[MM-133]: updated the channel setting list values

66fc89c

Kshitij-Katiyar requested a review from mickmister June 12, 2024 10:03

mickmister requested a review from fmartingr June 12, 2024 14:23

[MM-133]: resolved conflict

5ff77f7

raghavaggarwal2308 added this to the v1.9.0 milestone Jul 2, 2024

fmartingr approved these changes Jul 2, 2024

View reviewed changes

server/command.go Outdated Show resolved Hide resolved

mickmister reviewed Jul 2, 2024

View reviewed changes

raghavaggarwal2308 added 2 commits July 2, 2024 23:17

Merge branch 'master' of github.com:mattermost/mattermost-plugin-zoom…

ad2e197

… into MM-133

[MM-542] Review fixes:

df05023

1. Removed unused params from function 2. Update constant name 3. Remove status code from values

[MM-542] Fixed confusion in channel settings modal

8583cac

mickmister reviewed Jul 4, 2024

View reviewed changes

[MM-546] Remove bin folder

5f0a6bf

raghavaggarwal2308 requested a review from wiggin77 as a code owner July 4, 2024 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

ayusht2810 commented Jan 17, 2024 •

edited by raghavaggarwal2308

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading

raghavaggarwal2308 left a comment

raghavaggarwal2308 commented Feb 26, 2024

raghavaggarwal2308 commented Mar 1, 2024

ayusht2810 commented May 2, 2024

mickmister left a comment

mickmister May 13, 2024

Kshitij-Katiyar Jun 6, 2024

mickmister May 13, 2024

mickmister May 13, 2024

Kshitij-Katiyar Jun 6, 2024

mickmister Jun 19, 2024

Kshitij-Katiyar commented Jun 6, 2024

mickmister commented Jun 6, 2024

Kshitij-Katiyar commented Jun 11, 2024

raghavaggarwal2308 commented Jul 1, 2024

fmartingr left a comment

mickmister Jun 19, 2024

raghavaggarwal2308 commented Jul 2, 2024

mickmister left a comment

mickmister Jul 4, 2024

raghavaggarwal2308 Jul 4, 2024

	ChannelName: submitRequest.CallbackId,
	ChannelDisplayName: submitRequest.CallbackId,

	func (p *Plugin) checkChannelPreference(channelID string) (bool, int, error) {
	func (p *Plugin) isChannelRestrictedForMeetings(channelID string) (bool, int, error) {

[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

Are you sure you want to change the base?

[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

Conversation

ayusht2810 commented Jan 17, 2024 • edited by raghavaggarwal2308 Loading

Summary

Ticket Link

Screenshots

What to test?

codecov bot commented Jan 17, 2024 • edited Loading

Codecov Report

raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

raghavaggarwal2308 commented Feb 26, 2024

raghavaggarwal2308 commented Mar 1, 2024

ayusht2810 commented May 2, 2024

mickmister left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kshitij-Katiyar commented Jun 6, 2024

mickmister commented Jun 6, 2024

Kshitij-Katiyar commented Jun 11, 2024

raghavaggarwal2308 commented Jul 1, 2024

fmartingr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raghavaggarwal2308 commented Jul 2, 2024

mickmister left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayusht2810 commented Jan 17, 2024 •

edited by raghavaggarwal2308

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading