This ticker implementation is flawed

[david-ju]

Hi, I just noticed you implementation is flawed when manually adding and deleting items. Let me give you an example:
Suppose I have one item in my ticker, the ticker will show as follows:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1"
Then I add another item:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 2"
When it proceeds with scrolling:
"item 1 item 1 item 1 item 1 item 2 item 1 item 1 item 1 item 1 item 1 item 1"
So now there are 11 "item 1" and 1 "item 2", the correct ticker contents should be:
"item 1 item 2 item 1 item 2 item 1 item 2 item 1 item 2 item 1 item 2 item 1"
(which it also shows if the ticker has two items initially)

Also when deleting items, the items are deleted immediatly from the ticker. In my opinion this also incorrect, the items should continue to scroll until there out view and just not be added to the ticker again.

I hope it's clear what I mean, I can provide you with a sample if you want to.

[jonmifsud]

Hi David, you do have a point.

Mixing up both your points, when you add an item, to one which has repeated
items, how would you expect it to behave? Reduce the number of "item 1"
items when they are out of screen to balance out?

On 3 April 2015 at 10:47, DavidLibido [email protected] wrote:

Hi, I just noticed you implementation is flawed when manually adding and
deleting items. Let me give you an example:
Suppose I have one item in my ticker, the ticker will show as follows:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1
item 1"
Then I add another item:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1
item 2"
When it proceeds with scrolling:
"item 1 item 1 item 1 item 1 item 2 item 1 item 1 item 1 item 1 item 1
item 1"
So now there are 11 "item 1" and 1 "item 2", the correct ticker contents
should be:
"item 1 item 2 item 1 item 2 item 1 item 2 item 1 item 2 item 1 item 2
item 1"
(which it also shows if the ticker has two items initially)

Also when deleting items, the items are deleted immediatly from the
ticker. In my opinion this also incorrect, the items should continue to
scroll until there out view and just not be added to the ticker again.

I hope it's clear what I mean, I can provide you with a sample if you want
to.

—
Reply to this email directly or view it on GitHub
#28.

[david-ju]

I think so, if I understand correctly.
To clarify, initally just one item:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1"
Then add another:
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 2"
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 2 item 1"
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 2 item 1 item 2"
"item 1 item 1 item 1 item 1 item 1 item 1 item 1 item 2 item 1 item 2 item 1"
"item 1 item 1 item 1 item 1 item 1 item 1 item 2 item 1 item 2 item 1 item 2"
"item 1 item 1 item 1 item 1 item 1 item 2 item 1 item 2 item 1 item 2 item 1"
"item 1 item 1 item 1 item 1 item 2 item 1 item 2 item 1 item 2 item 1 item 2"
And so on.