Make sure that weekdays displayed in newsletter scheduler are the same regardless the current user timezone #1993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the implementation was using
new Date(x, y, z)
, which takes into account the current user timezone. So, for a user browsing using timezone Asia/Calcutta, for example, the weekdays displayed in the newsletter scheduler started by Monday. For another timezone, for example America/New_York, the weekdays started by Sunday. The fix is to pass the UTC timezone tonew Date()
. This PR also includes unit tests that reproduce this issue.Fixes: CV2-4845.
Type of change
How has this been tested?
TDD. Unit tests added.
Checklist
propTypes
are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers