Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structures refactor #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deprale
Copy link

@deprale deprale commented May 5, 2024

removed repeating code + a bit of a refactor so it's easier to build upon without repeating code over and over, when you need to generate additional structures u can just add to the map, and the path to the structure in the header file.

I think it can be further refactored by recursively parsing the directories rather than including them each 1 by 1, this way people can also just mod structures without adding any code (but it'd require a lot of refactoring)

structurePaths could also just be a const char array I guess.

@meemknight
Copy link
Owner

yo, I don't really look at pool requests because it's harder for me to maintain the code like this, thanks for the help tho and if you want to help some more in the future you can message me on discord and we can exchange ideas 💪

tag me there, I'm low level game dev
https://discord.gg/eehehsPAka

@meemknight
Copy link
Owner

and yes I would need to remake structures big time 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants