Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performances: Stop initializing large vector that we’re not going to read #568

Open
irevoire opened this issue Apr 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@irevoire
Copy link
Member

When streaming a payload with meilisearch-rust, we have to convert a structure implementing AsyncRead to a structure implementing Stream.
This means I have to call poll_read, which have a &[u8] in parameter.

Currently, to avoid doing anything wrong, I initialize every byte of my buffer to zero here:

this.buf.resize(*this.capacity, 0);

But ideally, this shouldn’t be necessary since we’re never reading these bytes before writing to it.

@irevoire irevoire added the enhancement New feature or request label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant