upgrade sdl3 #327
Open
upgrade sdl3 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-rvw
force-pushed
the
main
branch
2 times, most recently
from
feb0da8
to
fd37097
Compare
T-rvw
commented
Oct 10, 2023
Comment on lines
252
to
+258
| // Center the window | ||
| SDL_DisplayMode dm; | ||
| SDL_GetDesktopDisplayMode(0, &dm); | ||
| int screenWidth = dm.w; | ||
| int screenHeight = dm.h; | ||
| int windowX = (screenWidth - width) / 2; | ||
| int windowY = (screenHeight - height) / 2; | ||
| SDL_SetWindowPosition(m_pSDLWindow, windowX, windowY); | ||
| //const SDL_DisplayMode* dm = SDL_GetCurrentDisplayMode(); | ||
| //int screenWidth = dm->w; | ||
| //int screenHeight = dm->h; | ||
| //int windowX = (screenWidth - width) / 2; | ||
| //int windowY = (screenHeight - height) / 2; | ||
| //SDL_SetWindowPosition(m_pSDLWindow, windowX, windowY); |
T-rvw
commented
Oct 10, 2023
Comment on lines
+265
to
+303
| //if (!pFilePath) | ||
| //{ | ||
| // return; | ||
| //} | ||
| // | ||
| //std::string iconFilePath = CDEDITOR_RESOURCES_ROOT_PATH; | ||
| //iconFilePath += pFilePath; | ||
| // | ||
| //int width, height, originFormat; | ||
| //int depth = 32; | ||
| //int channels = STBI_rgb_alpha; | ||
| //void* pImageData = stbi_load(iconFilePath.c_str(), &width, &height, &originFormat, STBI_rgb_alpha); | ||
| //if (nullptr == pImageData) | ||
| //{ | ||
| // return; | ||
| //} | ||
| // | ||
| //uint32_t maskR, maskG, maskB, maskA; | ||
| //if constexpr(SDL_BYTEORDER == SDL_BIG_ENDIAN) | ||
| //{ | ||
| // maskR = 0xff000000; | ||
| // maskG = 0x00ff0000; | ||
| // maskB = 0x0000ff00; | ||
| // maskA = 0x000000ff; | ||
| //} | ||
| //else | ||
| //{ | ||
| // maskR = 0x000000ff; | ||
| // maskG = 0x0000ff00; | ||
| // maskB = 0x00ff0000; | ||
| // maskA = 0xff000000; | ||
| //} | ||
| // | ||
| //SDL_Surface* pSDLSurface = SDL_CreateRGBSurfaceFrom(pImageData, width, height, depth, | ||
| // channels * width, maskR, maskG, maskB, maskA); | ||
| // | ||
| //SDL_SetWindowIcon(m_pSDLWindow, pSDLSurface); | ||
| //SDL_FreeSurface(pSDLSurface); | ||
| //stbi_image_free(pImageData); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to SDL3 which presents good improvements in GDC 2023.
https://schedule.gdconf.com/session/open-source-game-development-summit-simple-directmedia-layer-past-present-and-future/892854