Remove continue label

Fixes arogozine#29
michaelmairegger · May 24, 2024 · 6ef3d9c · 6ef3d9c
1 parent fd77907
commit 6ef3d9c
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 18 deletions.
diff --git a/src/async/_private/distinctAsync.ts b/src/async/_private/distinctAsync.ts
@@ -7,17 +7,19 @@ export const distinctAsync = <TSource>(
 
     async function* iterator() {
         const distinctElements: TSource[] = []
-        outerLoop:
         for await (const item of source) {
+            let found = false
             for (const distinctElement of distinctElements) {
-                const found = await comparer(distinctElement, item)
-                if (found) {
-                    continue outerLoop
+                if (await comparer(distinctElement, item)) {
+                    found = true
+                    break
                 }
             }
 
-            distinctElements.push(item)
-            yield item
+            if (!found) {
+                distinctElements.push(item)
+                yield item
+            }
         }
     }
 

diff --git a/src/parallel/_private/distinctAsync.ts b/src/parallel/_private/distinctAsync.ts
@@ -6,16 +6,18 @@ export const distinctAsync = <TSource>(
     comparer: IAsyncEqualityComparer<TSource>): IParallelEnumerable<TSource> => {
     const generator = async () => {
         const distinctElements: TSource[] = []
-        outerLoop:
         for (const item of await source.toArray()) {
+            let found = false
             for (const distinctElement of distinctElements) {
-                const found = await comparer(distinctElement, item)
-                if (found) {
-                    continue outerLoop
+                if (await comparer(distinctElement, item)) {
+                    found = true
+                    break
                 }
             }
 
-            distinctElements.push(item)
+            if (!found) {
+                distinctElements.push(item)
+            }
         }
 
         return distinctElements

diff --git a/src/sync/_private/distinctAsync.ts b/src/sync/_private/distinctAsync.ts
@@ -7,17 +7,19 @@ export const distinctAsync = <TSource>(
 
     async function* iterator() {
         const distinctElements: TSource[] = []
-        outerLoop:
-        for (const item of source) {
+        for await (const item of source) {
+            let found = false
             for (const distinctElement of distinctElements) {
-                const found = await comparer(distinctElement, item)
-                if (found) {
-                    continue outerLoop
+                if (await comparer(distinctElement, item)) {
+                    found = true
+                    break
                 }
             }
 
-            distinctElements.push(item)
-            yield item
+            if (!found) {
+                distinctElements.push(item)
+                yield item
+            }
         }
     }