[PT Run][Calculator] Ignore regional formatting

[evinnichenko]

Summary of the Pull Request

PR Checklist

• Closes: PT-Run calculator: disable number formats for the input #32739
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Not needed
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Initial issue has been inconsistency when pressing . on numpad in Russian, which would produce non-English decimal separators (namely, for my locale, , instead of .). This PR aims to fix that by introducing a new optional flag IgnoreRegionalFormatting and editing the input in NumberTranslator.cs to remove all but last separators and replace the last with the locale-appropriate one.

Validation Steps Performed

Open PT Run and enter same mixed decimal number with different decimal separators, and see that if the flag is turned on, the exact symbol for the decimal separator doesn't matter. Couple tests were created to check it.

[evinnichenko]

One drawback is that upon reviewing it, the current solution only works for select locale pairs where decimal separator of the second language is same as the group separator in the first language (e.g. en/ru pair works fine). If this condition doesn't apply, then this fix doesn't work.

TODO: add functionality to cover for other separators. In particular, Windows seems to only have four default separators (,, ., , and '), so NumberTranslator.cs/GetSplitRegex() could be modified to use different regex, including all four of them, if the flag is raised. Theoretically, this would allow to expand it from certain particular locale pairs to all of them except the ones where symbol used is custom (e.g. you can make 1,234.5 show up as 1-234\5 by editing the Windows settings).

[evinnichenko]

@microsoft-github-policy-service agree

[htcfreek]

I worry that the two settings can break each other or at least confuse users. Can we switch to a drop down "Select how to handle seperators on input" with the options system default, en-us (,) and auto-detect? Thoughts?