Feedback wanted - [Mouse Jump] - Customisable appearance - borders, margins, colours, etc #33486

mikeclayton · 2024-06-23T23:26:49Z

Summary of the Pull Request

This is a follow-up to #32838 and #27511 to introduce some style settings to control the visual appearance of the Mouse Jump preview popup - previous work in #32838 added the style rendering code but didn't surface it in the Settings UI project and left the visual appearance as it was previously, but generated using some new rendering code.

This PR adds Settings UI options - it shows a live preview in the "Appearance and behaviour" section of the Mouse Jump settings which updates dynamically as colour and layout options are edited.

It's a Work In Progress, but I'd appreciate a review of the functionality in this PR so far, primarily in terms of whether the overall approach fits in with general PowerToys design guidelines, or whether it needs a major rethink before I spend a lot of time refining it. I'm not so worried about the code right now - mostly just the visual appearance and functionality of the new Mouse Jump Settings UI options.

Here's a (slightly rubbish) capture of it in action for reference:

mousejump-styles.mp4

…renced by SettingsUI - microsoft#25482

htcfreek · 2024-06-24T05:50:01Z

@mikeclayton
Regarding the live preview panel: I don't think that we need a live preview of the screen. A fake image should be enough. And I think we should only show one desktop in the preview. Reasons for my thoughts are performance and visibility.

mikeclayton · 2024-06-24T15:04:45Z

@htcfreek - I can change the preview to use a static image as a fake desktop - the most recent unit tests do this anyway, so I can just re-use that. It might be worth leaving two screens though - the setting currently labelled "Screen Margin" defines the spacing between the individual screens - if there was just one screen the effect of this setting wouldn't be visible in the preview.

(I think the setting names and descriptions probably all need some thought as well, but I'm keen to get the layout and functionality right first...)

htcfreek · 2024-06-24T15:29:45Z

@htcfreek - I can change the preview to use a static image as a fake desktop - the most recent unit tests do this anyway, so I can just re-use that. It might be worth leaving two screens though - the setting currently labelled "Screen Margin" defines the spacing between the individual screens - if there was just one screen the effect of this setting wouldn't be visible in the preview.

Sounds both good to me. Saw that point with the two screens late.

(I think the setting names and descriptions probably all need some thought as well, but I'm keen to get the layout and functionality right first...)

Sounds good.

…oft#25482

…tings resource strings

mikeclayton · 2024-06-28T21:51:52Z

@htcfreek - I've replaced the live preview of the current desktop with a static image: - see below.

The static "fake desktop" image it uses is is here: https://github.com/microsoft/PowerToys/pull/33486/files#diff-7fa63c54234718f0f78bb369b5da042242265e8487e4fa2e8cdca1107c57b5ac and it's based on my original animation at https://github.com/mikeclayton/FancyMouse. If it's not really suitable (e.g. doesn't meet UI guidelines / colours / logos / similarity to real products / etc ) would you be able to ask someone in the core team to create one we can use as that might be quicker than me trying to meet the design criteria.

It would be good to hear if there's any other UI feedback as well...

mikeclayton · 2024-06-28T21:55:04Z

@htcfreek - I'm also having a bit of trouble with the Azure DevOps pipeline. I've added a new project - MouseJump.Common - but I'm getting an error about the target framework version - I've had a dig, but I can't see what's different compared to other projects that are building successfully before it (e.g. ImageResizer).

Are you able to take a look and see if you can see what the issue is?

For reference, the pipeline error is:

https://dev.azure.com/ms/PowerToys/_build/results?buildId=589043&view=logs&j=b6b44f60-477e-5b36-eeeb-589df0c177de&t=f5043f15-036d-5d3b-8695-92dff4115778

##[error]C:\hostedtoolcache\windows\dotnet\sdk\8.0.302\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): Error NETSDK1047: Assets file 'D:\a_work\1\s\src\modules\MouseUtils\MouseJump.Common\obj\project.assets.json' doesn't have a target for 'net8.0-windows10.0.20348.0/win-x64'. Ensure that restore has run and that you have included 'net8.0-windows10.0.20348.0' in the TargetFrameworks for your project. You may also need to include 'win-x64' in your project's RuntimeIdentifiers. [D:\a_work\1\s\src\modules\MouseUtils\MouseJump.Common\MouseJump.Common.csproj]

htcfreek · 2024-06-29T00:46:35Z

@htcfreek - I'm also having a bit of trouble with the Azure DevOps pipeline. I've added a new project - MouseJump.Common - but I'm getting an error about the target framework version - I've had a dig, but I can't see what's different compared to other projects that are building successfully before it (e.g. ImageResizer).

Are you able to take a look and see if you can see what the issue is?

For reference, the pipeline error is:

https://dev.azure.com/ms/PowerToys/_build/results?buildId=589043&view=logs&j=b6b44f60-477e-5b36-eeeb-589df0c177de&t=f5043f15-036d-5d3b-8695-92dff4115778

(...)

The order/structure of the two "common" .csproject files is different. Maybe that is the reason. 🤔🤷🏻‍♂️ But for such problems I am the wrong person to ask. 😅

mikeclayton · 2024-06-29T07:00:39Z

@htcfreek - no worries.

I'm at a bit of a loss as to what else to try though - is there someone on the core team that I could @ mention who might be able to help?

htcfreek · 2024-06-29T07:47:05Z

@htcfreek - no worries.

I'm at a bit of a loss as to what else to try though - is there someone on the core team that I could @ mention who might be able to help?

Jaime (jaimecbernardo) I think.

mikeclayton · 2024-06-29T08:58:34Z

@jaimecbernardo - I'm having some problems with the Azure DevOps Pipeline that I've not been able to resolve - is this something you're able to take a look at?

In this PR I've moved some of the MouseJumpUI code into a new project - MouseJump.Common - which lets me re-use some of the code in the SettingsUI project for configuring options.

However, when the build runs I get this error:

https://dev.azure.com/ms/PowerToys/_build/results?buildId=589043&view=logs&j=b6b44f60-477e-5b36-eeeb-589df0c177de&t=f5043f15-036d-5d3b-8695-92dff4115778

##[error]C:\hostedtoolcache\windows\dotnet\sdk\8.0.302\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): Error NETSDK1047: Assets file 'D:\a_work\1\s\src\modules\MouseUtils\MouseJump.Common\obj\project.assets.json' doesn't have a target for 'net8.0-windows10.0.20348.0/win-x64'. Ensure that restore has run and that you have included 'net8.0-windows10.0.20348.0' in the TargetFrameworks for your project. You may also need to include 'win-x64' in your project's RuntimeIdentifiers. [D:\a_work\1\s\src\modules\MouseUtils\MouseJump.Common\MouseJump.Common.csproj]

I've tried comparing the MouseJump.Common to other projects and I can't see any differences that might cause the problem, so I'm a bit stuck with what else to try. If you're able to shed any light it would be massively appreciated...

Herry0092 · 2024-06-29T09:26:49Z

PowerToys.sln

-		{D9C5DE64-6849-4278-91AD-9660AECF2876}.Debug|x64.Build.0 = Debug|x64
-		{D9C5DE64-6849-4278-91AD-9660AECF2876}.Debug|x86.ActiveCfg = Debug|x64
-		{D9C5DE64-6849-4278-91AD-9660AECF2876}.Debug|x86.Build.0 = Debug|x64
-		{D9C5DE64-6849-4278-91AD-9660AECF2876}.Release|ARM64.ActiveCfg = Release|ARM64


Feeling in my head

I'm not sure that's the issue - D9C5DE64-6849-4278-91AD-9660AECF2876 is the project guid for MouseJumpUI.UnitTests - see

PowerToys/src/modules/MouseUtils/MouseJumpUI.UnitTests/MouseJumpUI.UnitTests.csproj

Line 8 in 3b7adbe

<ProjectGuid>{D9C5DE64-6849-4278-91AD-9660AECF2876}</ProjectGuid>

That was one other thing I changed as part of moving some code to MouseJump.Common - I moved the test code to a new MouseJump.Common.UnitTests project and removed MouseJumpUI.UnitTests...

I think it's pointed me in the right direction though. It looks like for whatever reason the project GUIDs are wrong in the solution file compared to the one specified in the *.csproj files.

I've just removed and re-added the projects to the solution and the diff looks like this (check the guid changes at the end of the lines):

-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MouseJump.Common", "src\modules\MouseUtils\MouseJump.Common\MouseJump.Common.csproj", "{F35E1EF3-C2AE-4407-8029-92B8F2B4A382}" +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MouseJump.Common", "src\modules\MouseUtils\MouseJump.Common\MouseJump.Common.csproj", "{923DF87C-CA99-4D1C-B1D2-959174E95BFA}" -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MouseJump.Common.UnitTests", "src\modules\MouseUtils\MouseJump.Common.UnitTests\MouseJump.Common.UnitTests.csproj", "{6A10C2B0-92AE-4928-996B-FCF55D2E3F39}" +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MouseJump.Common.UnitTests", "src\modules\MouseUtils\MouseJump.Common.UnitTests\MouseJump.Common.UnitTests.csproj", "{D5E42C63-57C5-4EF6-AECE-1E2FCA725B77}"

I'll try committing that shortly and fingers crossed it'll fix the build error...

So that didn't work :-(

I've noticed the x64 build seems to be pulling slightly different builds of dlls - https://dev.azure.com/ms/PowerToys/_build/results?buildId=589287&view=logs&j=0f660c0a-4423-5c5d-276b-f98b39c69e13&t=34873f2b-5f38-5b1d-35e6-61803dc82c39

System.Drawing.dll 8.0.624.26909 PowerToys.ImageResizer.deps.json ... PowerToys.MouseJumpUI.deps.json ... 8.0.624.26715 PowerToys.MouseJump.Common.deps.json Detected 4 libraries that are mentioned with different version across the dependencies.

Currently trying to work out what's causing that in case it's related.

I'm wondering if it's something do to with the nuget package caching in the Azure DevOps pipeline...

The latest commit (adding <RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers> to the *.csproj seems to have fixed the NETSDK1047 error (more by luck than judgement I feel), but I'm still seeing failures from the verifyDepsJsonLibraryVersions.ps1 build step.

Will continue to investigate...

mikeclayton added 3 commits June 23, 2024 22:48

[Mouse Jump] - moved "common" code into new library so it can be refe…

22d7cdb

…renced by SettingsUI - microsoft#25482

[Mouse Jump] - deleted a few redundant classes - microsoft#25482

b8ce5b5

[Mouse Jump] - added style settings to SettingUI - microsoft#25482

c5b8f6f

mikeclayton marked this pull request as draft June 23, 2024 23:27

mikeclayton added 6 commits June 24, 2024 22:53

[Mouse Jump] - fixing xaml formatting with xstyler

cae2a88

[Mouse Jump] - fixing broken tests

ad5a740

[Mouse Jump] - change to static desktop image in settings ui - micros…

3fc1699

…oft#25482

[Mouse Jump] - fixing build - microsoft#25482

c71c1ce

[Mouse Jump] - fixing build - microsoft#25482

269ce53

[Mouse Jump] - changed settings ui preview desktop image, updated set…

90aca3c

…tings resource strings

Herry0092 reviewed Jun 29, 2024

View reviewed changes

mikeclayton added 6 commits June 29, 2024 13:50

[Mouse Jump] - fixing build - #

ad1660b

[Mouse Jump] - trying to fix build (add RuntimeIdentifiers per Awake) -

3a69f40

microsoft#25482

[Mouse Jump] - trying to fix build (<UseWindowsForms> -> true) - micr…

57009c0

…osoft#25482

[Mouse Jump] - trying to fix build (remove system.drawing.common) - m…

9a16593

…icrosoft#25482

[Mouse Jump] - trying to fix build (remove <UseWindowsForms>) - micro…

c7f48c4

…soft#25482

[Mouse Jump] - trying to fix build (re-adding System.Drawing.Common) - …

d84d073

…microsoft#25482

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feedback wanted - [Mouse Jump] - Customisable appearance - borders, margins, colours, etc #33486

Feedback wanted - [Mouse Jump] - Customisable appearance - borders, margins, colours, etc #33486

mikeclayton commented Jun 23, 2024

htcfreek commented Jun 24, 2024

mikeclayton commented Jun 24, 2024

htcfreek commented Jun 24, 2024

mikeclayton commented Jun 28, 2024 •

edited

Loading

mikeclayton commented Jun 28, 2024 •

edited

Loading

htcfreek commented Jun 29, 2024 •

edited

Loading

mikeclayton commented Jun 29, 2024 •

edited

Loading

htcfreek commented Jun 29, 2024

mikeclayton commented Jun 29, 2024 •

edited

Loading

Herry0092 Jun 29, 2024

mikeclayton Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024

Feedback wanted - [Mouse Jump] - Customisable appearance - borders, margins, colours, etc #33486

Are you sure you want to change the base?

Feedback wanted - [Mouse Jump] - Customisable appearance - borders, margins, colours, etc #33486

Conversation

mikeclayton commented Jun 23, 2024

Summary of the Pull Request

htcfreek commented Jun 24, 2024

mikeclayton commented Jun 24, 2024

htcfreek commented Jun 24, 2024

mikeclayton commented Jun 28, 2024 • edited Loading

mikeclayton commented Jun 28, 2024 • edited Loading

htcfreek commented Jun 29, 2024 • edited Loading

mikeclayton commented Jun 29, 2024 • edited Loading

htcfreek commented Jun 29, 2024

mikeclayton commented Jun 29, 2024 • edited Loading

Herry0092 Jun 29, 2024

Choose a reason for hiding this comment

mikeclayton Jun 29, 2024 • edited Loading

Choose a reason for hiding this comment

mikeclayton Jun 29, 2024 • edited Loading

Choose a reason for hiding this comment

mikeclayton Jun 29, 2024 • edited Loading

Choose a reason for hiding this comment

mikeclayton Jun 29, 2024

Choose a reason for hiding this comment

mikeclayton commented Jun 28, 2024 •

edited

Loading

mikeclayton commented Jun 28, 2024 •

edited

Loading

htcfreek commented Jun 29, 2024 •

edited

Loading

mikeclayton commented Jun 29, 2024 •

edited

Loading

mikeclayton commented Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024 •

edited

Loading

mikeclayton Jun 29, 2024 •

edited

Loading