Fixed non-building without ExecutionPolicy Bypass #86
Conversation
| .arg("Bypass") | ||
| .arg("-Scope") | ||
| .arg("Process") | ||
| .arg("-Force;") |
There was a problem hiding this comment.
Huh, now that I'm thinking about this, couldn't we just sign the script? I'm not sure who to ask for this internally, but I bet there's a chance we could do that.
Apropos, instead of a lot of args (even before your PR) I feel like anything past the -c should just be a single string, wrapped in single quotes. It's the command to be executed after all.
There was a problem hiding this comment.
PowerShell is optional and may not be present on the box, disabled, locked down, etc. and the user may not have permission to use that execution policy.
I would instead call out to Get-ExecutionPolicy and throw an error if the state is not a desirable one.
| .arg("Bypass") | ||
| .arg("-Scope") | ||
| .arg("Process") | ||
| .arg("-Force;") |
There was a problem hiding this comment.
FWIW, we should prefer powershell -NoProfile -ExecutionPolicy Bypass -c foo-bar-baz instead of trying to set-executionpolicy as an inline script 🙂
Spent a lot of time trying to figure out why sudo wasn't building - cargo was just spitting out a vague error with no reason for the build to fail.
As a result, I found out that this is happening because... Running PowerShell scripts is disabled on the system by default. And the error message issued by PowerShell is simply lost somewhere in the PS subroutine call in build.rs.
This change automatically enables scripts to run in the current build session, so the program builds correctly.