Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire not used in execute #32

Open
raxan opened this issue Feb 24, 2017 · 1 comment
Open

Expire not used in execute #32

raxan opened this issue Feb 24, 2017 · 1 comment

Comments

@raxan
Copy link

raxan commented Feb 24, 2017

In execute() method the param $expire seem not used, here:

https://github.com/mikecao/sparrow/blob/master/sparrow.php#L756-L762

seem that fetch() check inside cached file expiration, here for example:

https://github.com/mikecao/sparrow/blob/master/sparrow.php#L1297

is this an issue or missing check of expiration? seem only file cache check it.

thanks

@mikecao
Copy link
Owner

mikecao commented Feb 25, 2017

You're right, it looks like the execute method doesn't use it. However everything should still work. Only the file cache checks the expire value, because all the other caches, like memcached handle expiration natively. See the store method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants