Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @license notations from all JS files #3107

Open
ewpatton opened this issue Jan 30, 2024 · 4 comments
Open

Remove @license notations from all JS files #3107

ewpatton opened this issue Jan 30, 2024 · 4 comments

Comments

@ewpatton
Copy link
Member

Any jsdoc with @license annotations gets included in the final build product. This increases the JS build non-trivially since the license is replicated for each JS file in blocklyeditor. We should remove the annotation to decrease the build size. This would should not be done until after the Blockly update to reduce merge conflicts.

@Abdullahkhanspn
Copy link

Hey @ewpatton myself Abdullah , currently a Third yr student , I want to do this task . I am new in this can u please tell me is it important to locally run the complete software or i can directly remove the @Licence notations from the JS files ?

@JustinFrost47
Copy link
Contributor

Hi @ewpatton , I would like to work on this issue, can i start working on it?

@JustinFrost47
Copy link
Contributor

just to be sure, the goal here is to just remove '@license' annotation while retaining other annotations like "@fileoverview" and author info , right?

@ewpatton
Copy link
Member Author

ewpatton commented Mar 5, 2024

We are waiting on the completion of our work updating to the latest Blockly to do this as a number of the files affected by this request are deleted in that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants