Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing test/samples/line_numbers.md #219

Closed
mtelka opened this issue Jun 29, 2024 · 1 comment
Closed

sdist is missing test/samples/line_numbers.md #219

mtelka opened this issue Jun 29, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@mtelka
Copy link

mtelka commented Jun 29, 2024

The sdist at PyPI is missing the test/samples/line_numbers.md file and so the testing fails:

=================================== FAILURES ===================================
__________________________ TestLineNumbers.test_main ___________________________

self = <test_line_numbers.TestLineNumbers testMethod=test_main>

    def test_main(self):
        # see line_numbers.md for a description of how the test works.
        NUMBER_OF_LINE_NUMBERS_TO_BE_CHECKED = 13
>       with open("test/samples/line_numbers.md", "r") as fin:
E       FileNotFoundError: [Errno 2] No such file or directory: 'test/samples/line_numbers.md'

test/test_line_numbers.py:27: FileNotFoundError
=========================== short test summary info ============================
FAILED test/test_line_numbers.py::TestLineNumbers::test_main - FileNotFoundEr...
=================== 1 failed, 263 passed, 1 skipped in 0.81s ===================
pbodnar added a commit that referenced this issue Jul 6, 2024
* add basic configuration files
* fix the completeness of the "test" folder
* exclude common temp/cache files
@pbodnar pbodnar added this to the 1.4.0 milestone Jul 6, 2024
@pbodnar pbodnar added the bug label Jul 6, 2024
@pbodnar pbodnar self-assigned this Jul 6, 2024
@pbodnar
Copy link
Collaborator

pbodnar commented Jul 6, 2024

@mtelka, thanks for the report. I've fixed the issue by the commit above, together with adding some more files to the built package.

Letting the issue open for a while, so that you or anyone else can provide feedback to the change.

@pbodnar pbodnar closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants