Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing description of politeness_dict object #2

Open
EmilHvitfeldt opened this issue Nov 15, 2018 · 1 comment
Open

Missing description of politeness_dict object #2

EmilHvitfeldt opened this issue Nov 15, 2018 · 1 comment

Comments

@EmilHvitfeldt
Copy link
Collaborator

I'm missing some information about where the politeness_dict is coming from. If you supply the source I don't mind adding the documentation!
@EmilHvitfeldt
Copy link
Collaborator Author

And on a related note, shouldn't the name of the feature be sent_polite instead of n_polite as the politeness function isn't counting words but instead summing weights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EmilHvitfeldt