Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why it doesn't work for "tinymce"? #27

Open
ivangusev opened this issue Oct 16, 2019 · 10 comments
Open

Why it doesn't work for "tinymce"? #27

ivangusev opened this issue Oct 16, 2019 · 10 comments
Labels

Comments

@ivangusev
Copy link

Installing "tinymce/tinymce" it simply ignores "extra" section.

@mnsami
Copy link
Owner

mnsami commented Oct 17, 2019

hello @ivangusev

Basically, my plugin is sticking to the default composer package types which are listed here https://getcomposer.org/doc/04-schema.md#type except for the type project but the tinymc has set the type to be component

but may be i can look into this later, but i just wanted to explain the issue briefly

@ivangusev
Copy link
Author

hi, @mnsami

Thanks for reply! I really need to install tinymce in different vendor folder, because it is supposed to be requested from public. Would be awesome if i can do it with your plugin. Or may be you can suggest me other solution/plugin?

@mnsami
Copy link
Owner

mnsami commented Oct 17, 2019

@ivangusev I'll check and get back to you :)

@mnsami
Copy link
Owner

mnsami commented Oct 21, 2019

hello @ivangusev can you try to require this version of my plugin
composer require mnsami/composer-custom-directory-installer:dev-allow-custom-packages-types

and see if tinymce works well afterwards

Let me know of the results

@ivangusev
Copy link
Author

hi, @mnsami

It works like a charm! Thanks a lot, great work!

@mnsami
Copy link
Owner

mnsami commented Oct 22, 2019

i think this library will work better and server your purpose better than this
https://packagist.org/packages/robloach/component-installer

it is more focused on js components

I would recommend checking it out @ivangusev

@mnsami
Copy link
Owner

mnsami commented Nov 6, 2019

@ivangusev can you check the package I mentioned, it makes more sense to use the component-install package rather than mine, it means the more correct way to go, but I want your validation of course :)

And I want to drop this pending branch.

Can you please get back to me.

@ivangusev
Copy link
Author

@mnsami i just remember before i found your package i tried the one you mentioned. It was some issue there. I can try again, in next few days when i get a chance. Okay?

@ivangusev
Copy link
Author

ivangusev commented Nov 8, 2019

Hi @mnsami, component-install package has been deprecated. Anyway i tried and it works but it installs "require.js" thing which i don't want. Do you know how to disable this "require.js" install?
I also tried oomphinc/composer-installers-extender, but it doesn't use an installer-paths whatever i write in "extra" section.

@liborm85
Copy link

Hi @mnsami , feature from allow-custom-packages-types branch works perfectly. Please, can you release new version with with feature? It will help me a lot, because lot of javascript packages use type component. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants