Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Implement Send & Receieve capabilities for Close Remote Tab #20808

Open
skhamis opened this issue Jun 26, 2024 · 2 comments
Open

[Meta] Implement Send & Receieve capabilities for Close Remote Tab #20808

skhamis opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
A-S Relates to Application Services

Comments

@skhamis
Copy link
Contributor

skhamis commented Jun 26, 2024

Closing tabs remotely has been completed on Desktop and Android and the Sync team wants to implement on iOS. Link to the Sync Epic: https://mozilla-hub.atlassian.net/browse/SYNC-4089

I think the best way to go about this is to split the send & receive into separate PRs as that'll make it easier to review and reason about (sending will have significantly more UX to cover).

[ ] Ability to receive close tab commands from other devices
[ ] Ability to send and undo close tab commands to other devices
[ ] Notifications when receiving close tab commands and deeplinking to the closed tabs when notification is tapped

┆Issue is synchronized with this Jira Task

@skhamis skhamis added the A-S Relates to Application Services label Jun 26, 2024
@skhamis skhamis self-assigned this Jun 26, 2024
@data-sync-user
Copy link
Collaborator

➤ Norberto Andres Furlan commented:

Sammy Khamis can you clarify what is the ask for the iOS Team? Also, I think we should take a look and fix this one https://mozilla-hub.atlassian.net/browse/FXIOS-9315 ( https://mozilla-hub.atlassian.net/browse/FXIOS-9315|smart-link ) before moving forward with the closing tabs. Happy to chat more about it. Thanks!

@data-sync-user
Copy link
Collaborator

➤ Sammy Khamis commented:

Norberto Andres Furlan, I’ll update the issue to make it clearer but the Sync team will be working on the implementation of this. The main ask of the iOS team is advice/feedback on the PRs that will be coming through! Thanks for linking that bug, we’ll make sure it’s properly prioritized with the rest of the teams work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-S Relates to Application Services
Projects
None yet
Development

No branches or pull requests

2 participants