New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: lint should check for 'unknown files' in src dir #17

Open

gregglind opened this issue Nov 2, 2017 · 1 comment

Labels

Contributor

gregglind commented Nov 2, 2017

Discussion:

Drawback: during DEV it's important to allow unversioned / unknown files into the addon for testing.
BUT if the build local and it's not repeatable, this is a footgun.
we could allow a DEV var to override, but then people will use it!

Suggestion: only allow git 'added' or 'ignored' files. This ties us to git though. Maybe it's a lint warning for a while?

Contributor Author

gregglind commented Nov 2, 2017

See:

https://stackoverflow.com/questions/3801321/git-list-only-untracked-files-also-custom-commands

My favorite:

git ls-files --others --exclude-standard

motin changed the title ~~ENH: lint should check for 'unknown files' in addon dir~~ ENH: lint should check for 'unknown files' in src dir

motin added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment