Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-firefox enh: screenshots, pings, more #24

Open
gregglind opened this issue Nov 3, 2017 · 4 comments
Open

run-firefox enh: screenshots, pings, more #24

gregglind opened this issue Nov 3, 2017 · 4 comments

Comments

@gregglind
Copy link
Contributor

Should run-firefox take screenshots? How often? Store them where?
Telemetry... should it print all shield-study, shield-study-addon telemetry? how to catch those?

Maybe it should screenshot every time there is a telemetry ping

@gregglind
Copy link
Contributor Author

THe screenshotting api i want looks more like this:

  • if ENV.screenshots=true or such:

    • have spots in the addon that request "screenshotNow(filename)".

Then I can do test runs that take screenshots at all the right times.

@gregglind
Copy link
Contributor Author

Listening for a custom event from selenium-webdriver

https://stackoverflow.com/questions/35884230/can-my-webdriver-script-catch-a-event-from-the-webpage

@gregglind
Copy link
Contributor Author

Conclusion: trying to signal FROM THE ADDON that 'you should take a screenshot' seems... weird and not right.

I think it's better to make that an explicit part of the script run. OR if you are running manual, it is on you to take screenshots.

@motin
Copy link
Contributor

motin commented Mar 2, 2019

"print all shield-study, shield-study-addon telemetry" is covered by 3013174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants