Popup not opening

[jhonatasrm]

Requirement for Contributing a Pull Request

• Put an X between the brackets on this line if you have done all of the
  following:
  • You agree to license your code under the project's open source license
    (MPL 2.0).
  • Your branch is based off the current master.
  • You did not include merge commits in pull requests; include only commits
    with the new relevant code.

Identify the Bug

#206

Description of the Change

Was added try-catch when verifying the chosen product.

Alternate Designs

no

Possible Drawbacks

no

[dannycolin]

We should leave the catch empty to avoid debugging logs in the production version.

[WesleyBranton]

I'm torn on this. I'd much rather have it logged as a proper console.error(). I feel that using an empty catch to silently suppress an error is not good practice.

[jhonatasrm]

The console.error instead of the console.log, was added to be more visible on the console, and also the part that verifies the 'firefox-preview' was removed.

[dannycolin]

@jhonatasrm Do you have step-to-reproduce instructions? I'm concerned that simply wrapping it in a try...catch results in silently failing to remove firefox-preview from the localStorage. We should probably find a solution that always successed to remove it.

[WesleyBranton]

I would prefer a more generic approach, since it seems strange to have a rule exclusively for firefox-preview. Instead, maybe we should have a constant array of all valid products and then filter out any from the storage API that do not appear in the list.

[jhonatasrm]

I would prefer a more generic approach, since it seems strange to have a rule exclusively for firefox-preview. Instead, maybe we should have a constant array of all valid products and then filter out any from the storage API that do not appear in the list.

I agree.. I don't know if we need that rule tbh, once he was removed right?

[jhonatasrm]

@jhonatasrm Do you have step-to-reproduce instructions?

Yes, in the issue #206.

[jhonatasrm]

The verification for 'firefox-preview' has been removed, as discussed earlier. For some reason that part was checking if the chooseProduct contained the 'firefox-preview'.