Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance only vertical #18

Open
thany opened this issue May 18, 2011 · 5 comments
Open

Distance only vertical #18

thany opened this issue May 18, 2011 · 5 comments

Comments

@thany
Copy link

thany commented May 18, 2011

Shadow distance can only get a vertical length, not horizontal.

Maybe a slider control is not really fit for a two-dimensional number heh ;)

@mrflix
Copy link
Owner

mrflix commented May 18, 2011

hello thany - thanks for contributing!

the distance is abstracted: it's x and y ratio is calculated by the angle.

@thany
Copy link
Author

thany commented May 18, 2011

Then maybe an option to switch between "distance" and "offset", where the latter one is what I was missing?

@mrflix
Copy link
Owner

mrflix commented May 18, 2011

Sorry, but I don't get your point:
box-shadow is defined by max. five attributes:
- horizontal offset
- vertical offset
- blur radius
- spread distance
- color

how these attributes are mapped in layerstyles:
- the horizontal and vertical distance are calculated through the angle and the distance (the angle splits up the distance into horizontal and vertical proportion)
- blur radius = blur
- spread = size (this is slightly misleading as someone already noted - i'll fix the naming)

Maybe head back to layerstyles to check the combination of distance and the angle while watching the code change might clear this up.

@thany
Copy link
Author

thany commented May 18, 2011

I understand your point. I was referring to an option to switch between setting the abstracted distance and explicit X/Y values.

@mrflix
Copy link
Owner

mrflix commented May 18, 2011

Ah okay. No i won't implement that. Try alt key while changing the changing the angle!

@mrflix mrflix closed this as completed May 18, 2011
@mrflix mrflix reopened this May 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants