Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradients bug #4

Open
nicooprat opened this issue May 11, 2011 · 6 comments
Open

Gradients bug #4

nicooprat opened this issue May 11, 2011 · 6 comments

Comments

@nicooprat
Copy link

HI,

When playing with gradients (after having deleted a "color point"), I got this error on line 84 of tools.js :
"Cannot read property 'length' of undefined element"

Very great tool, btw. Should be added to the real Photoshop ;)

@mrflix
Copy link
Owner

mrflix commented May 11, 2011

thanks!
yeah, the gradient editor somehow kills the whole gradient array at some point - didn't figure out why yet. I'm planning on rewriting the whole gradient editor since main features are not yet implemented (see gradienteditor.js from line 62). hopefully on that way i'll figure out the problem.

@aziz
Copy link
Contributor

aziz commented May 17, 2011

gradient editor is kinda buggy, it's a great idea to refactor it. I've been bitten by a bug when double clicking on a color stop to change a color. here is the error in my console:

An invalid or illegal string was specified" code: "12
error source line: [Break On This Error] gradient.addColorStop(pos, color); 

tools.js (line 195)

@mrflix
Copy link
Owner

mrflix commented May 17, 2011

Indeed. I'm planning a major rewrite.

(see pointer and middlepoint objects inside gradienteditor.js - they are not yet in use)

On 17.05.2011, at 14:10, [email protected] wrote:

gradient editor is kinda buggy, it's a great idea to refactor it. I've been bitten by a bug when double clicking on a color stop to change a color. here is the error in my console:

An invalid or illegal string was specified" code: "12
error source line: [Break On This Error] gradient.addColorStop(pos, color);

tools.js (line 195)

Reply to this email directly or view it on GitHub:
#4 (comment)

@GittiHab
Copy link

GittiHab commented May 3, 2014

I just tested this great tool and I noticed I can't edit the Gradient at all (I can only change between the presets)

@mrflix
Copy link
Owner

mrflix commented May 7, 2014

@GittiHab you have to double-click onto the color rectangles under the preview (photoshop behaviour):
layerstyles_gradient

@GittiHab
Copy link

GittiHab commented May 8, 2014

@mrflix That's the part that didn't work. I redownloaded it and it now works. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants