Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test coverage for ComparableGroup.consistent_with #8

Open
mscarey opened this issue Aug 20, 2020 · 0 comments
Open

add test coverage for ComparableGroup.consistent_with #8

mscarey opened this issue Aug 20, 2020 · 0 comments

Comments

@mscarey
Copy link
Owner

mscarey commented Aug 20, 2020

I don't understand why the self_factor.contradicts(other_factor) call didn't have a context param. And I don't exactly understand how the all_generic_factors_match method is needed. Adding the missing context param fixed the broken test test_consistent_factor_groups_with_context, but I don't understand why the all_generic_factors_match doesn't make the context param redundant.

@mscarey mscarey changed the title add test coverage for Procedure.consistent_with add test coverage for ComparableGroup.consistent_with Aug 27, 2020
@mscarey mscarey transferred this issue from mscarey/AuthoritySpoke Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant