Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe not received on device UUID change. #467

Closed
emvarunp opened this issue Jun 20, 2024 · 6 comments · Fixed by #473
Closed

Probe not received on device UUID change. #467

emvarunp opened this issue Jun 20, 2024 · 6 comments · Fixed by #473
Assignees
Labels

Comments

@emvarunp
Copy link

emvarunp commented Jun 20, 2024

When UUID of a device is changed by * uuid command from adapter. probe data will not be sent for the updated device in mqtt sink.

The mqtt client connected to the agent will only receive probe information of agent device and the device with old uuid.
when the uuid changes the agent will not send a new probe data with the changed uuid.

I expected a new probe will be published by agent under the topic with new uuid.

Thank you.
V

@wsobel wsobel added the bug label Jun 20, 2024
@wsobel wsobel self-assigned this Jun 20, 2024
@wsobel
Copy link
Member

wsobel commented Jun 21, 2024

Which MQTT sink are you using? The one with one DataItem per topic or the second that has probe, current, and sample?

Can you also attach your agent.cfg file so I can repeat what you're reporting.

There may be some issue regarding what behavior we should have since changing the UUID may also change the topic paths which would be confusing. I'm open to suggestions.

Best

  • W

@emvarunp
Copy link
Author

Hi @wsobel.

We are using the mqtt2service which has probe ,current, sample.

Attaching the agent configuration below.
agent_config.txt

When the UUID of the device changes the agent shall send a new probe under the topic path with new UUID as it would make it easier for us.

If there is any other way for the mqtt client to know if the UUID has been changed then we would like your suggestion.

Thank you.
V

@wsobel
Copy link
Member

wsobel commented Jun 21, 2024

That helps a lot, thanks! - W

@emvarunp
Copy link
Author

emvarunp commented Jul 1, 2024

Hi @wsobel.
Is there any update for approaching this bug.? Would help us to know.

Thanks,
V

@wsobel
Copy link
Member

wsobel commented Jul 1, 2024

I'm working on the fix. The fix is nearly complete but it required more change than I originally thought.

The old code took some shortcuts to change the machine uuid. This worked for some simple use cases, but did not execute the full device change workflow which is much more complex.

I need to fix some tests they made assumptions on the smaller workflow. This will take a couple of days to sort out.

@emvarunp
Copy link
Author

emvarunp commented Jul 1, 2024

Thank you for the quick update @wsobel.

@emvarunp emvarunp closed this as completed Jul 2, 2024
@emvarunp emvarunp reopened this Jul 2, 2024
@wsobel wsobel linked a pull request Jul 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants