Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of code for vocabularies #14

Open
2 tasks done
davideC00 opened this issue Jul 23, 2019 · 0 comments
Open
2 tasks done

Optimization of code for vocabularies #14

davideC00 opened this issue Jul 23, 2019 · 0 comments

Comments

@davideC00
Copy link
Contributor

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

In the folder "vocabularies" there are 2 vocabularies with a lot in common

Please describe what you expected to happen and why.

An abstact class with the feature in common for classification and education. this is better for maintenance of the code

Describe the solution you'd like

  1. An abstract class smd-vocabulary maybe better in smd-simple-metadata
  2. SMDE_Metadata_Classification and SMDE_Metadata_Education extends SMD_Metadata_Vocabulary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davideC00