-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlowFrames 1.41-1.42-1.43 Changelog #275
base: main
Are you sure you want to change the base?
Conversation
…ed. So it will work. - Intel QSV Decoder (Experimental/Only JPG) - Interpolation Frames JPG support added. - Faster through higher -WThread count. - No more slowdowns because of broken logger function, that has been disabled. There are no side effects of the functions disabled. - Drag and Drop for "Output Directory" has been removed, which would sometimes accidentally take the video into this field, which is wrong. Draging into this "OUTPUT Directory" Field will drag into the video tab as it suppossed to happen. - Changed default Temp Folder to "C:\Users\{Username}\AppData\Local\Temp", so Windows Indexer will not recognize the files and start indexing, which slows down the cpu. You can of course select the temp folder, there are other options. - LastUsedAi Name by default is RIFE/CUDA, since this is the fastest for people with NVIDIA GPUS.
FlowFrames Version 1.41 Please put this folder in the "FlowframesData" Folder, It will put the new rife.py, version.ini and natsort library which is needed into the right places. Normally this should work. I just fear, it might not work because of following function, which we might have to comment out for now: ShowTotalPerformance(). Because on non Nvidia GPU, this might indeed give an error, but there is not way to check this out unfornuately. |
Resetting does not work very well with interpolated frames, need to look into this. |
- Status Fixed - Intel QSV higher quality images - Interpolated Frames ImageMagick Blending higher quality fixed problem. - Log file will not slow down FlowFrames, it will write all 5 seconds at once. - Resetting interpolation frames format has been fixed. - Settings Tab was broken in Visual Studio, now has been fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
- Play Sound, if finished. - BMP/WEBP interpolated frames supported (still jpg/png is recommended). - Ai rife py starting time is 1500 instead of 3500. - Rife W-Threads option added. Default is thread count times 2. Shows your current core/thread count also. - Added "Performance Settings" Preset with my best performance settings enabled. Your settings my vary.
- A file will be created, which is called "Fileshavebeencompressed.ini" in the "FlowframesData" folder, because delete the ini file or resetting, this would cause the compact function to check if files have been compressed, which they are actually are. However this would take around 10 seconds. This will be generated automatically for the first time and also, if you delete it manually. - Different presets have been added. - GUI has been a little bit more better, smaller changes. - Reset Button added, don't know if somebody needs it, but will empty everything written.
@n00mkrad Can you merge? |
@n00mkrad ???? |
@n00mkrad Can you merge? |
@n00mkrad it would be cool to at least respond to @jensdraht1999. He obviously put a lot of effort into this. |
Is it now showing a conflict with the branch, or have they finally started merging your code? |
@Astalavista1655 This will not work anyway. He has ignored me, not even mentionion me. I left it with him. |
I will look into it once I finish the messy VFR changes |
I do have to look into the blending which appears to only work with PNG frames right now. Does not apply to RIFE-NCNN-VS though. |
1.) Cuda is faster than Rife NCNN, but because of broken logger function, it seems the other way around. It actually is fast, but it gets slower, because flowframes log function is broken. Please debug in visual studio and look which function consumes everything. And this has been proven by all people here: #160 2.) QSV and jpeg are two different things. QSV decoder will extract images with jpeg faster from h264 videos faster than pure cpu image extraction. 2.5.) Jpeg interpolated frames are supported and faster too, because a lot of cpu cycles are consumed png creation. However creating jpeg files for interpolation is much much faster. Flowframes would if run for about 30 minutes, consume 15-20% of the cpu will all these things combined, however, after fixing logging function, using temp directory, using jpeg interpolated frames, it would not only not slowdown, it would even be much faster in the beginning. 3.) Please drag and drop to the place in the image and see what happens if you try to interpolate a video. Spoiler alert. It will not work: 4.) WebP interpolated frames are supported. 5.) Stuff like cpu/gpu/disk support are good for people who want to know and see directly if there are problems and are totally okay to add as function. 6.) Bleding with anything other than png has been also fixed by me. You have to play with imagemagick library. For you not to build everything, I will upload the exe file here so you can test out yourself. https://anonymfile.com/d7qj/flowframes.7z There are a few improvments too like chaning w-threads and whatnot. Please check this thread: PS:
|
All people that tried cuda after my release say that the whole video takes only half of the time. Please look at the threads. |
I do not think, because if the program is gonna crash anyway, it would have not written it to the file either. For this purpose we will have to use the visual studio in debug mode to see, where it crashes. |
Use RIFE-NCNN-VS. CUDA with frame extraction and writing is a dead end. I benchmarked it on a 4090 and NCNN is still a bit faster. NCNN VS: 16s total processing time CUDA pre-patch: 60s total processing time CUDA with your patch: 24s total processing time |
Can you send me the test video? I would like to test it out. I also need info: I have 1:16 min with NCNN/VS/Vapoursynth My settings: The sample file: |
I’ll break the dialogue a little here, will there be an update to RIFE 4.13? In the meantime, I switched to SVP, Flowframes are still more familiar |
Hello another test with longer video, Top 10 Best Anime Fights of Spring 2023 (1080p_24fps_H264-128kbit_AAC) Video Audio with 3x interpolation in both cases and waited for both of them 5 minutes too cool down: Rife Cuda: VRAM USED: 0,71 GB NCNN VS: VRAM USED: 3.46 GB It's about 4 minutes faster than NCNN-VS. But I think Cuda could be much faster, if we somehow could directly process the video to video, so the cpu would not be bottlenecked by JPEG/PNG creation. By the way, I already use Pytorch 2.0, which has reduced VRAM usage and still is fast it was. However one of the best option release with Pytorch 2.0. is Pytorch compile, which would increase the performance, but is sadly not available for Windows. |
Running RIFE (CUDA)... This time I used NVENC Encoder too. The VRAM usage would go 1.01 GB when it was encoding and then going back to 0,71 GB. |
4.13 is already working in the repo version, yes |
I will keep these things in mind but for now I prioritize the VapourSynth based implementations since they are a lot more flexible. As soon as 1.41 is out I will look at some of the changes here. |
@n00mkrad I also try my best to somehow manage to get PytorchTRT Version working with direct video to video, but I cannot promise anything. Let's see, if PytorchTRT will be ready at that time. |
Why is it impossible to set a custom coefficient for RIFE 2.3? Is this a feature of the model? |
Hello, I followed the guide here #160 (comment) and compiled without no errors. Here is the beginning of the story... GPU core use and GPU VRAM use are increasing but the progress does not show how many frames and the process looks like it's progressing, but it's not. Can anyone help? Some SS here: |
The changes I made are only for Nvidia Cuda Rife, not for the other ones. However, if I would be you, please put it into another folder, which does not contain special turkish chars. Then try again, perhaps it works. There was this PR, which suppossed to correct this behavoir, but I could not test it out: |
FlowFrames 1.41 Changelog