From a613e9956d88d1958d2929d56685454895b1b1ba Mon Sep 17 00:00:00 2001 From: Antonio Lain Date: Fri, 27 May 2022 14:01:57 -0700 Subject: [PATCH 1/3] Fix for #131 --- src/poweredup-browser.ts | 4 ++-- src/webbleabstraction.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/poweredup-browser.ts b/src/poweredup-browser.ts index bd19561..9c81a69 100644 --- a/src/poweredup-browser.ts +++ b/src/poweredup-browser.ts @@ -130,9 +130,9 @@ export class PoweredUP extends EventEmitter { private _determineLPF2HubType (device: IBLEAbstraction): Promise { - return new Promise((resolve) => { + return new Promise(async (resolve) => { let buf: Buffer = Buffer.alloc(0); - device.subscribeToCharacteristic(Consts.BLECharacteristic.LPF2_ALL, (data: Buffer) => { + await device.subscribeToCharacteristic(Consts.BLECharacteristic.LPF2_ALL, (data: Buffer) => { buf = Buffer.concat([buf, data]); while (buf[0] <= buf.length) { const len = buf[0]; diff --git a/src/webbleabstraction.ts b/src/webbleabstraction.ts index 09a359d..9e09275 100644 --- a/src/webbleabstraction.ts +++ b/src/webbleabstraction.ts @@ -85,7 +85,7 @@ export class WebBLEDevice extends EventEmitter implements IBLEAbstraction { } - public subscribeToCharacteristic (uuid: string, callback: (data: Buffer) => void) { + public subscribeToCharacteristic (uuid: string, callback: (data: Buffer) => void): Promise { if (this._listeners[uuid]) { this._characteristics[uuid].removeEventListener("characteristicvaluechanged", this._listeners[uuid]); } @@ -108,7 +108,7 @@ export class WebBLEDevice extends EventEmitter implements IBLEAbstraction { callback(data); } - this._characteristics[uuid].startNotifications(); + return this._characteristics[uuid].startNotifications(); } From d3ccc7ac4187c3bff49b89483f553e97cca79f5a Mon Sep 17 00:00:00 2001 From: Antonio Lain Date: Fri, 27 May 2022 14:27:27 -0700 Subject: [PATCH 2/3] Change package name Signed-off-by: Antonio Lain --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index cb061d1..eccdeda 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "node-poweredup", + "name": "caf_node-poweredup", "version": "8.0.5", "description": "A Javascript module to interface with LEGO Powered Up components.", "homepage": "https://github.com/nathankellenicki/node-poweredup/", From 333d300fc47fd92891a1ed4892c331ed35e2a0e7 Mon Sep 17 00:00:00 2001 From: Antonio Lain Date: Fri, 27 May 2022 14:30:26 -0700 Subject: [PATCH 3/3] Undo change package name Signed-off-by: Antonio Lain --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index eccdeda..cb061d1 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "caf_node-poweredup", + "name": "node-poweredup", "version": "8.0.5", "description": "A Javascript module to interface with LEGO Powered Up components.", "homepage": "https://github.com/nathankellenicki/node-poweredup/",