Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the same node id check in network #171

Open
wenzeslaus opened this issue Mar 3, 2022 · 0 comments
Open

Remove the same node id check in network #171

wenzeslaus opened this issue Mar 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@wenzeslaus
Copy link
Member

The test for "Edge cannot begin and end with the same node" should not be there. Loop is not an error and with dropping dispersers between nodes, it yields non-trivial results.

            if (node_1_id == node_2_id) {
                throw std::runtime_error(
                    std::string("Edge cannot begin and end with the same node: ")
                    + node_1_text + " " + node_2_text);
            }
@wenzeslaus wenzeslaus added the bug Something isn't working label Mar 3, 2022
@wenzeslaus wenzeslaus self-assigned this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants