Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Inconsistent behavior of prod and local deployments and flaky broken link #426

Open
Adam-D-Lewis opened this issue Apr 11, 2024 · 0 comments
Labels
type: bug 🐛 Something isn't working

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Apr 11, 2024

Describe the bug

If you navigate to https://www.nebari.dev/docs/how-tos/pytorch-best-practices you will get a 301 redirect to https://www.nebari.dev/docs/how-tos/pytorch-best-practices/ (added trailing slash). The Why doesn't my code recognize the GPU(s) on Nebari? link on that page is broken when you click on it from https://www.nebari.dev/docs/how-tos/pytorch-best-practices/.

However, if you click on "Best practices for Pytorch on Nebari" in the sidebar then you are taken to https://www.nebari.dev/docs/how-tos/pytorch-best-practices and the "Why doesn't my code recognize the GPU(s) on Nebari?" links works as expected.
image

Note, however that you don't get the redirect response when navigating to http://localhost:3000/docs/how-tos/pytorch-best-practices when deploying the docs locally. I see we're deploying through Netlify, so maybe it's a netlify setting that is causing the discrepancy, but I'm not familiar enough with Netlify to know for sure.

The cause for the broken link when the trailing slash is added is because the link is relative and the trailing slash is not expected. See below.

Also see the FAQ answer to [Why doesn't my code recognize the GPU(s) on Nebari?][why gpus not recognized]

[pytorch installation matrix]: https://pytorch.org/get-started
[why gpus not recognized]: ../faq#why-doesnt-my-code-recognize-the-gpus-on-nebari

Expected behavior

No 301 redirect

How to Reproduce the problem?

see above

Command output

No response

Versions and dependencies used.

No response

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Apr 11, 2024
@Adam-D-Lewis Adam-D-Lewis changed the title [BUG] - Inconsistent behavior of prod and local deployments [BUG] - Inconsistent behavior of prod and local deployments and sometimes broken link Apr 11, 2024
@Adam-D-Lewis Adam-D-Lewis changed the title [BUG] - Inconsistent behavior of prod and local deployments and sometimes broken link [BUG] - Inconsistent behavior of prod and local deployments and flaky broken link Apr 11, 2024
@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Todo 📬
Development

No branches or pull requests

1 participant