Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling white/blacklist prefixes still leaves the functions in place #11

Open
bonzi opened this issue Jul 2, 2021 · 2 comments
Open

Comments

@bonzi
Copy link

bonzi commented Jul 2, 2021

Hi.

For my current setup, we require no whitelist/blacklisted prefixes, so they have been removed from the YAML file. This removed the declaration of the variables that store the prefixes, but not the functions that rely on them.

This seems like a large oversight as the code seems to understand not to implement the prefixes if not defined, but hasn't also cleaned up the filter functions that require those variables.

Thanks

@bswinnerton
Copy link
Contributor

Hi @bonzi,

This repository is no longer in use at Neptune Networks, so it hasn't been updated in a while. Pull requests welcome 🙂.

@bonzi
Copy link
Author

bonzi commented Jul 3, 2021

Hi @bswinnerton,

No worries, I'll try take a stab at the code at some point.

The repo is usually suggested in certain circles for beginners/etc so it would be good to keep it at least somewhat alive.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants