-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom type
is not retained as type, but rewritten as allOf: - $ref: ...
breaking nullable: true
spec in @ApiProperty
#2948
Comments
Would you like to create a PR for this issue? |
Sure, but I don't know what the solution would be here - what should the value of |
One solution looks like:
I will test with redoc.ly to see if it's acceptable. If it is, then I think we can just add this |
The only think redoc.ly will accept is:
so it seems like an easy fix |
Here is the source of our woes: swagger/lib/services/schema-object-factory.ts Lines 368 to 379 in 5404905
Extra keys that are not in the set of The list of supported keys needs to be expanded, or removed altogether. I'm not sure which one as I haven't read the OpenAPI spec to any level of detail. |
Is there an existing issue for this?
Current behavior
Custom
type
is not retained as type, but rewritten asallOf: - $ref: ...
breakingnullable: true
spec in@ApiProperty
In
@ApiProperty
when using something like:the rendered openapi.yaml is like:
tools like Redoc.ly then start to throw errors:
Minimum reproduction code
https://nothing.com
Steps to reproduce
see above
Expected behavior
Package version
7.3.0
NestJS version
10.3.3
Node.js version
20
In which operating systems have you tested?
Other
maybe related: #2645
maybe related: #2646
The text was updated successfully, but these errors were encountered: