need to set manticore_up early

[britcey]

The manticore_up metric only gets set at the end of Collect - if there are any errors Collect returns before it is set.

Ideally want to initialize it to 0 & set it to one at the end of Collect (I'm a bit unclear on the right way to do this otherwise this would be a PR)

[netgineer]

Hey, @britcey!
I'm not sure i understand what is the problem. Can you elaborate this issue? Some real-life example would be great.

[britcey]

Sure, that would have helped:

Call to manticore-exporter while manticore is running normally:

$ curl -s http://localhost:9247/metrics|grep 'manticore_up '
# HELP manticore_up Could the manticore server be reached.
# TYPE manticore_up gauge
manticore_up 1

Call to manticore-exporter while manticore (searchd) is not running:

$ curl -s http://localhost:9247/metrics|grep 'manticore_up '

(just get the go_* metrics)

Ideally, I want to alert when manticore_up == 0.

The 'return' at main.go:546 means the

ch <- prometheus.MustNewConstMetric(e.up, prometheus.GaugeValue, float64(status))

at main.go:790 never gets called. Same for the other 'return' calls in Collect.

I hacked in

ch <- prometheus.MustNewConstMetric(e.up, prometheus.GaugeValue, float64(0))

in each error block, with a final

ch <- prometheus.MustNewConstMetric(e.up, prometheus.GaugeValue, float64(1))

but surely there's a cleaner way to do that.