Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest: differentiate date_released and date_submitted #104

Open
joverlee521 opened this issue Aug 18, 2022 · 1 comment
Open

Ingest: differentiate date_released and date_submitted #104

joverlee521 opened this issue Aug 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

On Slack, @emmahodcroft pointed out that we are labeling the release date as date_submitted in the metadata TSV. These two dates usually aligned for SARS-CoV-2 sequences, but there is a noticeable difference in monkeypox sequences:

image

Once NCBI Virus adds submission date to their available fields, we can pull and include both dates in the metadata TSV.

@joverlee521 joverlee521 added the enhancement New feature or request label Aug 18, 2022
@j23414
Copy link
Contributor

j23414 commented Nov 18, 2022

Top right date seems to be UpdateDate_dt

Also described by NCBI documentation as "Modification date"

joverlee521 added a commit to nextstrain/ingest that referenced this issue Aug 23, 2023
Useful for knowing when the record was last updated in NCBI, which
@j23414 noted to be the "Modification date".¹

This will ultimately add a new field to the NDJSON output from
fetch-from-ncbi-virus, but it should not affect the final metadata
output of the ingest pipelines. Ingest pipelines usually define the
final metadata output columns in the config and would need to be updated
separately.

¹ nextstrain/mpox#104 (comment)
joverlee521 added a commit to nextstrain/ingest that referenced this issue Aug 24, 2023
Useful for knowing when the record was last updated in NCBI, which
@j23414 noted to be the "Modification date".¹

This will ultimately add a new field to the NDJSON output from
fetch-from-ncbi-virus, but it should not affect the final metadata
output of the ingest pipelines. Ingest pipelines usually define the
final metadata output columns in the config and would need to be updated
separately.

¹ nextstrain/mpox#104 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants