Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: include url field #76

Open
joverlee521 opened this issue Jun 21, 2022 · 2 comments
Open

ingest: include url field #76

joverlee521 opened this issue Jun 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

See #72 (comment)

Possible solution

GenBank urls can be specially added as https://www.ncbi.nlm.nih.gov/nuccore/<genbank_accession>
URLs for arbitrary non-GenBank sequences will have to be added through manual annotations.

@joverlee521 joverlee521 added the enhancement New feature or request label Jun 21, 2022
@jameshadfield
Copy link
Member

jameshadfield commented Jun 23, 2022

The logic here is a bit confusing (I'm documenting this now).

If "accession": "AY741551" is switched to "genbank_accession": {"value": "AY741551"} then auspice will automagically add the GenBank URL 😉 This is the best approach.

Otherwise we can switch to the following:

node_attrs: {
  accession: "AY74155",
  url: "https://www.ncbi.nlm.nih.gov/nuccore/AY74155"
}

Note that if we choose the latter, then neither "genbank_accession" nor "gisaid_epi_isl" can appear as a node_attr. However different nodes can use different approaches, which will be helpful if we have non-genbank strains.

@joverlee521
Copy link
Contributor Author

Yup, I was going through this logic in Auspice and figured the accession/url combo would be best for monkeypox to support non-GenBank sequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants