Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basicpy output should be split up by sample ID #27

Open
jmuhlich opened this issue Apr 11, 2024 · 1 comment
Open

basicpy output should be split up by sample ID #27

jmuhlich opened this issue Apr 11, 2024 · 1 comment
Assignees
@RobJY
Labels
bug Something isn't working

Comments

@jmuhlich
Copy link
Member

Description of the bug

basicpy output file paths/names are based only on the input filenames. If a run has multiple samples with the same filenames then their basicpy outputs will clash and overwrite each other.

Command used and terminal output

No response

Relevant files

No response

System information

No response
@jmuhlich jmuhlich added the bug Something isn't working label Apr 11, 2024
@RobJY RobJY self-assigned this Apr 25, 2024
@RobJY
Copy link
Contributor

RobJY commented Apr 25, 2024

I pushed a fix for this to my fork in branch 'issue_27'. I'll make a PR for it once #29 is merged.

RobJY added a commit to RobJY/mcmicro-nf-core that referenced this issue May 8, 2024
@RobJY
bug fix for issue nf-core#27; split basicpy output by ID
f26879f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobJY RobJY

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmuhlich @RobJY