Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-specified binning #40

Open
nhejazi opened this issue Apr 23, 2024 · 0 comments
Open

user-specified binning #40

nhejazi opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nhejazi
Copy link
Owner

nhejazi commented Apr 23, 2024

Via the grid_type argument to haldensify(), which is passed to format_long_hazards(), discretization and binning of the outcome variable (A) in the conditional density estimation routine g(A|W) is handled by functions that bin points based on an equal partitioning along the range of A ("equal_range") or into possibly uneven bins that contain roughly the same number of observations each ("equal_mass"), as happens at https://github.com/nhejazi/haldensify/blob/master/R/utils.R#L51-L63. It would be beneficial in many applications to allow the user to specify the binning/discretization themselves, given that these two simple routines may lead to suboptimal performance in many settings, e.g., when there are rare instances that fall far away from others among the set of observations. It would be beneficial to allow the relevant argument to take as input a set of cut points along the observed support at which the variable A will be discretized.

@nhejazi nhejazi self-assigned this Apr 23, 2024
@nhejazi nhejazi added the enhancement New feature or request label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant