Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimi-python packages with optional support for gRPC should be tested both with and without it #1919

Open
bkeryan opened this issue Apr 11, 2023 · 1 comment
Open

nimi-python packages with optional support for gRPC should be tested both with and without it #1919

bkeryan opened this issue Apr 11, 2023 · 1 comment

Comments

@bkeryan
Copy link
Contributor

bkeryan commented Apr 11, 2023

Description of issue

nidcpower, nidmm, nifgen, niscope, and niswitch have optional support for gRPC. However, they do not have any test coverage for configurations where gRPC is not installed. If these packages had a bug that prevented them from working when grpcio or protobuf is not installed, it would not be caught by the automated tests.

System report

N/A

Steps to reproduce issue

N/A
@bkeryan bkeryan mentioned this issue Apr 11, 2023
Merged
1 task
@ni-jfitzger
Copy link
Collaborator

Examples could test this, if they had their own venv without grpcio and protobuf installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkeryan @ni-jfitzger