Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cancel build" workflow #1994

Open
ni-jfitzger opened this issue Jul 31, 2023 · 0 comments
Open

Add "cancel build" workflow #1994

ni-jfitzger opened this issue Jul 31, 2023 · 0 comments

Comments

@ni-jfitzger
Copy link
Collaborator

Description of issue

System Tests and Travis CI take a long time to run (somewhere between 45 minutes and an hour and a half maybe?) and sometimes a contributor will push multiple commits to a PR in a short time, causing additional PR checks to be queued. But PR checks for the previous commits remain in the queue and aren't cancelled. This makes it take longer to get test results for the latest commit.

We should automatically cancel testing for previous commits of a PR when a new commit is pushed.
Luckily, there's an Action to help with that: cancel-workflow.
ni/grpc-device actually uses this action, already.

It may take a bit of research to properly use, but it would likely cut down on test time.
We should probably use a later version than ni/grpc-device currently does, so that we don't get node-js12 warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant