Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG defaults to writing Comment metadata in ID3v1.1 instead of ID3v2.x #370

Open
hobbsilla opened this issue Dec 3, 2015 · 5 comments
Open
Labels

Comments

@hobbsilla
Copy link

hobbsilla commented Dec 3, 2015

If I make changes to a files Comment metadata using NG's metadata editor it defaults to writing in ID3v1.1 and erases the Comment metadata in the ID3v2.x (tried this and replicated it with ID3v2.2, 2.3 and 2.4) and will cut itself off after 30 characters.
If I delete all of the metadata from ID3v1.1 and then try this NG duplicates all of the data from the 2.x metadata and does the same thing as described above.
In addition to this is also seems to create a blank Disc Number in ID3v2.x metadata if it didn't have one before. The Disc Number tick isn't that big of deal in comparison to the comments metadata complaint but it would be nice if both could be addressed together.
I used the latest version of kid3 at the time of this post to confirm the changes being made by NG.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@hobbsilla
Copy link
Author

Oh yes. I'm using El Capitan OSX with NGale 1.12.1 build 2454, installed it from the standard dmg file and these two issues were not something I had observed with previous versions.

@mook
Copy link
Member

mook commented Dec 4, 2015

I believe this was originally for Windows XP compatibility (Explorer's built in metadata handling only read id3v1). It is probably time to revisit that.

@freaktechnik
Copy link
Member

I knew @rsjtdrjgfuzkfg at some point said something about ID3 versions and windows explorer...
http://forum.getnightingale.com/thread-1012-post-4507.html#pid4507

@rsjtdrjgfuzkfg
Copy link
Member

The question is why did the behaviour change? Is that a build without the recent taglib? As iirc the recent taglib might additionally write ID3v1, but we internally use ID3v2.4 (and that should also be written to the file).

@hobbsilla
Copy link
Author

Since it sounds like I'm not alone in this problem would NGale contributors and developers be interested in pursuing a bounty if I created one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants