Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip hint should also prevent members from being compared #46

Open
nilslice opened this issue Jul 26, 2018 · 0 comments
Open

skip hint should also prevent members from being compared #46

nilslice opened this issue Jul 26, 2018 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@nilslice
Copy link
Owner

currently, // @protolock:skip hints prevent a proto member such as a message from being added to the proto.lock file. But if a hint was added after the proto.lock file was written, then protolock thinks the message was just removed and several conflicts are reported.

consider skipping the message in the comparison step in addition to the serialization step.
@nilslice nilslice added enhancement New feature or request question Further information is requested labels Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nilslice