-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] plugins.leap: safeLabels = [] does not disable auto-jump #1698
Comments
Indeed, empty lists and attrs are ignored during the translation to lua. setLabels.__empty = null; |
If we ever get to a point where all settings options (inc attrs and lists) are default-null, we might be able to change the behaviour to only omit null attrs? Maybe we could have a configurable helpers.toLuaObject'
{
omitNullAttrs = true;
omitEmptyAttrs = false;
multiline = false;
}
{
someNullAttr = null;
someEmptyAttrsAttr = { };
someEmptyListAttr = [ ];
}
=>
''
{ ["someEmptyAttrsAttr"] = { }, ["someEmptyListAttr"] = { } }
'' |
I think there used to be a reason for empty tables, I remember @GaetanLepage had done some stuff around that some time ago. A good test would be removing the empty attrs from a full config, and seeing how it increases. |
At some point, we did made the switch to stop ignoring empty attrs. It turned out to be bad. We had to rely on |
Unfortunately |
In lua, lists and dicts are both tables. |
You can also do |
On the Nix side, |
Can confirm, the type is This is caused by the underlying issue @traxys brought up in an unrelated discussion: The fact that |
leap
unstable e8057b6 (June 5)
N/A
Description
According to the documentation, setting
plugins.leap.safeLabels = []
should disable auto-jump, however it does not.Minimal, Reproducible Example (MRE)
Working Example of Auto-Jump Disabled
The text was updated successfully, but these errors were encountered: