Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions in common_space_learning #16

Open
DuanXu-97 opened this issue May 26, 2021 · 0 comments
Open

Questions in common_space_learning #16

DuanXu-97 opened this issue May 26, 2021 · 0 comments

Comments

@DuanXu-97
Copy link
Contributor

Hi, I think it‘s a really awesome work :)

I have a small question. During common space training with mini-batch, samples are taken from all entities with random.sample.

batch_pos = random.sample(entities, batch_size)
However, random.sample seems to be a sampling method with replacement. Does it result in some samples not being trained? If yes, is it correct?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant