Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong boxb found with newest code #21

Open
phycologia opened this issue Aug 17, 2022 · 9 comments
Open

wrong boxb found with newest code #21

phycologia opened this issue Aug 17, 2022 · 9 comments
Assignees

Comments

@phycologia
Copy link
Collaborator

previous version(s?) of the code identified boxb correctly, but now identifies incorrect sequences as boxb; all begin with "TAGCA"
accession numbers for sequences with this issue (all in order Nostocales):
KF417427.1
MK953008.1
MN15981.1

@callmcgovern
Copy link
Collaborator

@phycologia ; what does boxb end with in these cases?

@phycologia
Copy link
Collaborator Author

TGCTG! @callmcgovern

@nlabrad nlabrad self-assigned this Aug 26, 2022
@nlabrad
Copy link
Owner

nlabrad commented Aug 26, 2022

Can you paste what it's supposed to be? @phycologia

@nlabrad
Copy link
Owner

nlabrad commented Aug 29, 2022

I think I'm making progress on this one. It was actually BIG. It uncovered that it could be a problem in the future with other sequences. I have a working prototype of yet another algorithm but I think it's more robust now.

@nlabrad
Copy link
Owner

nlabrad commented Aug 29, 2022

@phycologia @callmcgovern I think this is fixed. I ran a test and it found the one @phycologia wanted above alongside another possible one. I set the BoxB length limit to 60 bases or you'd get a bunch more. I don't think they are ever that long, but keep an eye out.

@nlabrad
Copy link
Owner

nlabrad commented Aug 29, 2022

MN15981.1

was not found in genbank btw. The other two worked.

@phycologia
Copy link
Collaborator Author

@nlabrad ah my bad I was with fam for the weekend so I didn't your first comment til now! It sounds like you got it figured out, but just in case:
MK953008.1 proper box b is TAGCACCTGAAAGCAAAAAAGTCAGACTGCTG
KF417427.1 proper box b is TAGCACCTGAGATCAAAGAATCAGACTGCTG
MN152981.1 (my b on the typo) proper box b is TAGCAACTGGATGATAAAGAATCAGACTGCTG
what was BIG?! this sounds juicy

@nlabrad
Copy link
Owner

nlabrad commented Sep 2, 2022

seems to be working for the first two, but for the last one I get
BoxB:
Sequence CAGCGTATATTGAACAGAGATTGTTAACTGTTGAGTGTAGGCTG
Length: 44

    Thoughts?

@phycologia
Copy link
Collaborator Author

huh, I'm not sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants