Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review Bot] Activate the CI Bot as a reviewer #684

Open
3 of 4 tasks
leemgs opened this issue Dec 14, 2020 · 2 comments
Open
3 of 4 tasks

[Review Bot] Activate the CI Bot as a reviewer #684

leemgs opened this issue Dec 14, 2020 · 2 comments

Comments

@leemgs
Copy link
Collaborator

leemgs commented Dec 14, 2020 •
edited
Loading

When all CI checkers are successfully passed, let's append the approval as a reviewer in a PR's review list.

It aims to add the number of reviewers by applying the automatic review activity of CI bot.
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 14, 2020

:octocat: cibot: Thank you for posting issue #684. The person in charge will reply soon.

leemgs pushed a commit that referenced this issue Dec 17, 2020
Added cibot_review() API newly
8cb6be3 
Fixed issue #684

This commit is to add an API to do a review result on a pull request with curl
The API consists of five arguments as folows.
 * arg1: Token number
 * arg2: Event (e.g., APPROVE, REQUEST_CHANGES, or COMMENT)
 * arg3: Description
 * arg4: Commit ID
 * arg5: API address

Note that you can use this API such as the below statement.
```bash
message="All CI checkers are successfully passed. LGTM."

cibot_review $TOKEN "APPROVE" "$message" "$input_commit"
"$GITHUB_WEBHOOK_API/$GITHUB_ACCOUNT/${PRJ_REPO_UPSTREAM_SERVER}/pulls/$input_pr/reviews
```

Signed-off-by: Geunsik Lim <[email protected]>
@leemgs leemgs mentioned this issue Dec 17, 2020
Merged
leemgs pushed a commit that referenced this issue Dec 17, 2020
@leemgs
Added cibot_review() API newly
bb9d061 
Fixed issue #684

This commit is to add an API to do a review result on a pull request with curl
The API consists of five arguments as folows.
 * arg1: Token number
 * arg2: Event (e.g., APPROVE, REQUEST_CHANGES, or COMMENT)
 * arg3: Description
 * arg4: Commit ID
 * arg5: API address

Note that you can use this API such as the below statement.
```bash
message="All CI checkers are successfully passed. LGTM."

cibot_review $TOKEN "APPROVE" "$message" "$input_commit"
"$GITHUB_WEBHOOK_API/$GITHUB_ACCOUNT/${PRJ_REPO_UPSTREAM_SERVER}/pulls/$input_pr/reviews
```

Signed-off-by: Geunsik Lim <[email protected]>
@leemgs
Copy link
Collaborator Author

leemgs commented Dec 18, 2020

The statement below shows usage.

@leemgs leemgs changed the title Enable CI account as a reviewer in the review list [Review Bot] Enable CI account as a reviewer in the review list Dec 18, 2020
@leemgs leemgs changed the title [Review Bot] Enable CI account as a reviewer in the review list [Review Bot] Run CI account as a reviewer Dec 18, 2020
@leemgs leemgs changed the title [Review Bot] Run CI account as a reviewer [Review Bot] Activate the CI Bot as a reviewer Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leemgs @taos-ci