Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sell deletes rejected items if inventory is full #85

Open
Gabo6480 opened this issue Aug 22, 2022 · 0 comments
Open

[BUG] Sell deletes rejected items if inventory is full #85

Gabo6480 opened this issue Aug 22, 2022 · 0 comments
Assignees
@noahbclarkson
Labels
bug Something isn't working

Comments

@Gabo6480
Copy link

Describe the bug
If you try to sell an item stack through the sell interface, and the sell gets rejected, BUT your inventory space gets filled in the meantime, the rejected item stack is deleted.

Steps To Reproduce
1.- Open the sell interface.
2.- Place unsellable items on the interface for sale.
3.- Without finishing the sale, fill your inventory through any means.
4.- Close the sale and have the items rejected.
5.- Not profit.

Expected behavior
I either expect items not being able to enter the inventory, OR, having rejected items dropped around the player.

Minecraft Server Version
1.19.

Auto-Tune-Version
0.14.0.
@Gabo6480 Gabo6480 added the bug Something isn't working label Aug 22, 2022
noahbclarkson added a commit that referenced this issue Aug 30, 2022
@noahbclarkson
Work on #85 by dropping item if inventory is full
8f399a8 
This is a WIP fix for #85 that attempts to drop the item if the player's inventory is full.
LcyDev added a commit to LcyDev/Auto-Tune that referenced this issue Jan 13, 2023
@LcyDev
Applied noahbclarkson#85 to noahbclarkson#115
0751e59
noahbclarkson pushed a commit that referenced this issue Jan 13, 2023
@LcyDev
Bugfixes & Improvements (#116)
09380c2 
* Typos

* Added option to toggle web-server

* Added help & adminHelp command

* Fix #115

* Disabled item not found warning on /sell.
* Now item is given back to the player instead of disappearing.

* Update Config.java

* Added EnableCollection setting

* Applied #85 to #115
noahbclarkson pushed a commit that referenced this issue Feb 2, 2023
@LcyDev
Small fix (#117)
d7e64bb 
* Typos

* Added option to toggle web-server

* Added help & adminHelp command

* Fix #115

* Disabled item not found warning on /sell.
* Now item is given back to the player instead of disappearing.

* Update Config.java

* Added EnableCollection setting

* Applied #85 to #115

* Fixed Could not find shop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahbclarkson noahbclarkson

Labels
bug Something isn't working
Projects
Auto-Tune Bug Tracker
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gabo6480 @noahbclarkson