Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issues #1

Open
audunskj opened this issue Mar 6, 2017 · 1 comment
Open

Accessibility issues #1

audunskj opened this issue Mar 6, 2017 · 1 comment

Comments

@audunskj
Copy link

audunskj commented Mar 6, 2017

NRKBeta might be considered a "blog" so you might get around the accessibility rules from Difi. But anyway - accessibility could be improved.

  • Submit button should live inside a form.
  • Use fieldset for radio button descriptions

:)
@fabacab
Copy link
Contributor

fabacab commented Mar 12, 2017

Just a heads up, I'm actually in the process of addressing this in #6, which, when complete, will have moved the quiz into the HTML form element. Doing this also provides the ability to view and answer the quiz without requiring JavaScript.

fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
8242a85 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
16f0723 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
b605f64 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
117b7c9 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
8bc9976 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
3f76395 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
fabacab added a commit to fabacab/nrkbetaquiz that referenced this issue Mar 12, 2017
@fabacab
Modify the JavaScript component so it works seamlessly with no-JS WP.
c960969 
With this commit, the JavaScript component now renders itself inside a
`FORM` element, rather than outside. This begins addressing the issues
listed in nrkbeta#1, and means that both JavaScript and non-JavaScript
variations work; the JavaScript now creates inputs as the WordPress
back-end expects them.

Further, this commit also fixes the error animation, and changes the
animation for when the user enters the quiz answers correctly.
Previously, this component hid the comment form and revealed it when the
quiz was answered, but this required rendering the quiz outside the
form. With the above change, the animation has been changed to disabling
the comment form's textareas and re-enabling them when the quiz is
answered correctly, along with showing a bolded green success message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabacab @audunskj