enabled automatic status reply loading, bug fix, layout fix, gradle u…

…pdate

app/build.gradle

@@ -55,9 +55,9 @@ dependencies {
 	implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
 	implementation 'androidx.cardview:cardview:1.0.0'
 	implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
-	implementation 'androidx.media3:media3-exoplayer:1.2.0'
-	implementation 'androidx.media3:media3-ui:1.2.0'
-	implementation 'androidx.media3:media3-datasource-okhttp:1.2.0'
+	implementation 'androidx.media3:media3-exoplayer:1.2.1'
+	implementation 'androidx.media3:media3-ui:1.2.1'
+	implementation 'androidx.media3:media3-datasource-okhttp:1.2.1'
 	implementation 'androidx.viewpager2:viewpager2:1.0.0'
 	//noinspection GradleDependency
 	implementation 'com.squareup.okhttp3:okhttp:4.12.0'

app/src/main/java/org/nuclearfog/twidda/backend/async/StatusLoader.java

@@ -113,10 +113,6 @@ protected Result doInBackground(@NonNull Param param) {
 					}
 					return new Result(statuses, param.pos, null);
 
-				case Param.REPLIES_LOCAL:
-					statuses = db.getReplies(param.id);
-					return new Result(statuses, param.pos, null);
-
 				case Param.REPLIES:
 					if (param.minId == Param.NO_ID && param.maxId == Param.NO_ID) {
 						statuses = db.getReplies(param.id);
@@ -166,7 +162,6 @@ public static class Param {
 		public static final int USER_REPLIES = 3;
 		public static final int FAVORIT = 4;
 		public static final int REPLIES = 5;
-		public static final int REPLIES_LOCAL = 6;
 		public static final int SEARCH = 7;
 		public static final int USERLIST = 8;
 		public static final int PUBLIC = 9;

app/src/main/java/org/nuclearfog/twidda/backend/helper/update/UserListUpdate.java

@@ -40,15 +40,6 @@ public UserListUpdate(UserList list) {
 		isExclusive = false; // todo implement this
 	}
 
-	/**
-	 * set ID of an existing list to update
-	 *
-	 * @param listId ID of an existing list
-	 */
-	public void setId(long listId) {
-		this.listId = listId;
-	}
-
 	/**
 	 * get ID of the list
 	 *

app/src/main/java/org/nuclearfog/twidda/ui/activities/ProfileActivity.java

@@ -501,7 +501,7 @@ else if (v.getId() == R.id.page_profile_post_button) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (user != null) {
 			// confirmed unfollowing user
 			if (type == ConfirmDialog.PROFILE_UNFOLLOW) {

app/src/main/java/org/nuclearfog/twidda/ui/activities/ProfileEditor.java

@@ -320,7 +320,7 @@ public void onTextChanged(InputView inputView, String text) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		// leave without settings
 		if (type == ConfirmDialog.PROFILE_EDITOR_LEAVE) {
 			finish();

app/src/main/java/org/nuclearfog/twidda/ui/activities/SettingsActivity.java

@@ -306,7 +306,7 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[] permis
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		// remove account from database
 		if (type == ConfirmDialog.APP_LOG_OUT) {
 			settings.setLogin(null, true);

app/src/main/java/org/nuclearfog/twidda/ui/activities/StatusActivity.java

@@ -206,7 +206,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 		repost_name_button = findViewById(R.id.page_status_reposter_reference);
 		translate_text = findViewById(R.id.page_status_text_translate);
 		spoiler_hint = findViewById(R.id.page_status_text_sensitive_hint);
-		//card_container = findViewById(R.id.page_status_cards_container);
 
 		clip = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE);
 		statusLoader = new StatusAction(this);
@@ -666,7 +665,7 @@ else if (v.getId() == R.id.page_status_location_name) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.DELETE_STATUS) {
 			if (status != null) {
 				long id = status.getId();

app/src/main/java/org/nuclearfog/twidda/ui/activities/StatusEditor.java

@@ -370,7 +370,7 @@ public void stopProgress() {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		// retry uploading status
 		if (type == ConfirmDialog.STATUS_EDITOR_ERROR) {
 			updateStatus();

app/src/main/java/org/nuclearfog/twidda/ui/activities/UserlistActivity.java

@@ -209,7 +209,7 @@ public void onBackPressed() {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		// delete user list
 		if (type == ConfirmDialog.LIST_DELETE && userList != null) {
 			if (listLoaderAsync.isIdle()) {

app/src/main/java/org/nuclearfog/twidda/ui/adapter/listview/DropdownAdapter.java

@@ -65,7 +65,6 @@ public View getView(int position, View convertView, ViewGroup parent) {
 			textItem = convertView.findViewById(R.id.dropdown_textitem);
 			textItem.setTextColor(settings.getTextColor());
 			textItem.setTypeface(settings.getTypeFace());
-			textItem.setBackgroundColor(settings.getCardColor());
 		} else {
 			textItem = convertView.findViewById(R.id.dropdown_textitem);
 		}

app/src/main/java/org/nuclearfog/twidda/ui/dialogs/ConfirmDialog.java

@@ -6,7 +6,6 @@
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.widget.Button;
-import android.widget.CompoundButton;
 import android.widget.TextView;
 
 import androidx.annotation.NonNull;
@@ -172,7 +171,6 @@ public class ConfirmDialog extends DialogFragment implements OnClickListener {
 
 	private TextView title, message;
 	private Button confirm, cancel;
-	private CompoundButton remember;
 
 	private int type = 0;
 	private String messageStr = "";
@@ -193,7 +191,6 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
 		cancel = view.findViewById(R.id.confirm_no);
 		title = view.findViewById(R.id.confirm_title);
 		message = view.findViewById(R.id.confirm_message);
-		remember = view.findViewById(R.id.confirm_remember);
 		GlobalSettings settings = GlobalSettings.get(requireContext());
 
 		if (savedInstanceState == null)
@@ -228,9 +225,9 @@ public void onClick(View v) {
 				int type = (int) tag;
 				// get parent activity or fragment inplementing OnConfirmListener and return result
 				if (getParentFragment() instanceof OnConfirmListener) {
-					((OnConfirmListener) getParentFragment()).onConfirm(type, remember.isChecked());
+					((OnConfirmListener) getParentFragment()).onConfirm(type);
 				} else if (getActivity() instanceof OnConfirmListener) {
-					((OnConfirmListener) getActivity()).onConfirm(type, remember.isChecked());
+					((OnConfirmListener) getActivity()).onConfirm(type);
 				}
 			}
 			dismiss();
@@ -425,9 +422,8 @@ public interface OnConfirmListener {
 		/**
 		 * called when the positive button was clicked
 		 *
-		 * @param type     type of dialog
-		 * @param remember true if "remember choice" is checked
+		 * @param type type of dialog
 		 */
-		void onConfirm(int type, boolean remember);
+		void onConfirm(int type);
 	}
 }

app/src/main/java/org/nuclearfog/twidda/ui/dialogs/TimePickerDialog.java

@@ -14,7 +14,6 @@
 import androidx.annotation.Nullable;
 import androidx.fragment.app.DialogFragment;
 import androidx.fragment.app.Fragment;
-import androidx.fragment.app.FragmentActivity;
 import androidx.fragment.app.FragmentManager;
 
 import org.joda.time.DateTime;
@@ -134,15 +133,6 @@ public static void show(Fragment fragment, long time) {
 		}
 	}
 
-	/**
-	 * show timepicker with default value
-	 *
-	 * @param time selected time or '0' to select the current time
-	 */
-	public static void show(FragmentActivity activity, long time) {
-		show(activity.getSupportFragmentManager(), time);
-	}
-
 	/**
 	 *
 	 */

app/src/main/java/org/nuclearfog/twidda/ui/fragments/AccountFragment.java

@@ -128,7 +128,7 @@ public void onAccountRemove(Account account) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.REMOVE_ACCOUNT) {
 			if (selection != null) {
 				AccountAction.Param param = new AccountAction.Param(AccountAction.Param.REMOVE, selection);

app/src/main/java/org/nuclearfog/twidda/ui/fragments/AnnouncementFragment.java

@@ -107,7 +107,7 @@ protected void onReset() {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.ANNOUNCEMENT_DISMISS) {
 			AnnouncementAction.Param param = new AnnouncementAction.Param(AnnouncementAction.Param.MODE_DISMISS, selectedId);
 			announcementAction.execute(param, announcementResult);

app/src/main/java/org/nuclearfog/twidda/ui/fragments/DomainFragment.java

@@ -117,7 +117,7 @@ public boolean onPlaceholderClick(int index, long cursor) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.DOMAIN_BLOCK_REMOVE) {
 			DomainAction.Param param = new DomainAction.Param(DomainAction.Param.MODE_UNBLOCK, selectedDomain);
 			domainAction.execute(param, domainResult);

app/src/main/java/org/nuclearfog/twidda/ui/fragments/FilterFragment.java

@@ -122,7 +122,7 @@ public void onFilterRemove(Filter filter) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.FILTER_REMOVE) {
 			StatusFilterAction.Param param = new StatusFilterAction.Param(StatusFilterAction.Param.DELETE, selection.getId(), null);
 			filterAction.execute(param, filterRemoveCallback);

app/src/main/java/org/nuclearfog/twidda/ui/fragments/NotificationFragment.java

@@ -195,7 +195,7 @@ public void onActivityResult(ActivityResult result) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.NOTIFICATION_DISMISS) {
 			if (select != null) {
 				NotificationAction.Param param = new NotificationAction.Param(NotificationAction.Param.DISMISS, select.getId());

app/src/main/java/org/nuclearfog/twidda/ui/fragments/ScheduleFragment.java

@@ -161,7 +161,7 @@ public boolean onPlaceholderClick(long min_id, long max_id, int position) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (type == ConfirmDialog.SCHEDULE_REMOVE) {
 			if (selection != null) {
 				ScheduleAction.Param param = new ScheduleAction.Param(ScheduleAction.Param.REMOVE, selection.getId(), 0L);

app/src/main/java/org/nuclearfog/twidda/ui/fragments/StatusFragment.java

@@ -284,10 +284,7 @@ private void load(long sinceId, long maxId, int index) {
 				break;
 
 			case MODE_REPLY:
-				if (index == CLEAR_LIST)
-					request = new StatusLoader.Param(StatusLoader.Param.REPLIES_LOCAL, id, sinceId, maxId, CLEAR_LIST, search);
-				else
-					request = new StatusLoader.Param(StatusLoader.Param.REPLIES, id, sinceId, maxId, CLEAR_LIST, search);
+				request = new StatusLoader.Param(StatusLoader.Param.REPLIES, id, sinceId, maxId, CLEAR_LIST, search);
 				break;
 
 			case MODE_SEARCH:

app/src/main/java/org/nuclearfog/twidda/ui/fragments/TagFragment.java

@@ -217,7 +217,7 @@ public boolean onPlaceholderClick(long cursor, int index) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		if (selection != null) {
 			if (type == ConfirmDialog.UNFOLLOW_TAG) {
 				TagAction.Param param = new TagAction.Param(TagAction.Param.UNFOLLOW, selection.getName(), selection.getId());

app/src/main/java/org/nuclearfog/twidda/ui/fragments/UserFragment.java

@@ -282,7 +282,7 @@ public void onResult(@NonNull UsersLoader.Result result) {
 
 
 	@Override
-	public void onConfirm(int type, boolean remember) {
+	public void onConfirm(int type) {
 		// remove user from list
 		if (type == ConfirmDialog.LIST_REMOVE_USER) {
 			if (selectedUser != null) {

app/src/main/res/layout/dialog_confirm.xml

@@ -33,31 +33,6 @@
 		app:layout_constraintStart_toStartOf="parent"
 		app:layout_constraintTop_toBottomOf="@id/confirm_title" />
 
-
-	<com.kyleduo.switchbutton.SwitchButton
-		android:id="@+id/confirm_remember"
-		android:layout_width="wrap_content"
-		android:layout_height="wrap_content"
-		android:visibility="gone"
-		android:layout_margin="@dimen/confirm_button_margin"
-		app:layout_constraintStart_toStartOf="parent"
-		app:layout_constraintTop_toBottomOf="@id/confirm_message" />
-
-	<TextView
-		android:id="@+id/confirm_remember_label"
-		android:layout_width="0dp"
-		android:layout_height="wrap_content"
-		android:visibility="gone"
-		android:lines="1"
-		android:text="@string/confirm_remember"
-		android:textSize="@dimen/confirm_button_fontsize"
-		android:layout_marginStart="@dimen/confirm_text_margin"
-		android:layout_marginEnd="@dimen/confirm_text_margin"
-		app:layout_constraintStart_toEndOf="@id/confirm_remember"
-		app:layout_constraintTop_toTopOf="@id/confirm_remember"
-		app:layout_constraintBottom_toBottomOf="@id/confirm_remember"
-		app:layout_constraintEnd_toEndOf="parent" />
-
 	<Button
 		android:id="@+id/confirm_no"
 		android:layout_width="wrap_content"
@@ -70,7 +45,7 @@
 		app:layout_constraintHorizontal_chainStyle="packed"
 		app:layout_constraintHorizontal_bias="1"
 		app:layout_constraintStart_toStartOf="parent"
-		app:layout_constraintTop_toBottomOf="@id/confirm_remember"
+		app:layout_constraintTop_toBottomOf="@id/confirm_message"
 		app:layout_constraintBottom_toBottomOf="parent"
 		app:layout_constraintEnd_toStartOf="@id/confirm_yes"
 		style="@style/FeedbackButton" />
@@ -85,7 +60,7 @@
 		android:text="@android:string/ok"
 		android:textSize="@dimen/confirm_button_fontsize"
 		app:layout_constraintStart_toEndOf="@id/confirm_no"
-		app:layout_constraintTop_toBottomOf="@id/confirm_remember"
+		app:layout_constraintTop_toBottomOf="@id/confirm_message"
 		app:layout_constraintBottom_toBottomOf="parent"
 		app:layout_constraintEnd_toEndOf="parent"
 		style="@style/FeedbackButton" />

app/src/main/res/values-de/strings.xml

@@ -187,7 +187,6 @@
 	<string name="toolbar_title_filter">Status-Filter</string>
 	<string name="status_translate_text">übersetzen</string>
 	<string name="field_verified">verifiziert:\u0020</string>
-	<string name="confirm_remember">Entscheidung merken</string>
 	<string name="confirm_remove_account">Account aus der Liste entfernen?</string>
 	<string name="menu_select_account">Accounts</string>
 	<string name="menu_instance_show_all">zeige alle Benachrichtigungen</string>

app/src/main/res/values/strings.xml

@@ -318,7 +318,6 @@
 	<string name="status_translate_source">Translated by:\u0020</string>
 	<string name="status_translate_source_language">Language:\u0020</string>
 	<string name="field_verified">verified:\u0020</string>
-	<string name="confirm_remember">remember choice</string>
 	<string name="confirm_tag_unfollow">unfollow hashtag?</string>
 	<string name="confirm_tag_unfeature">unfeature hashtag?</string>
 	<string name="confirm_schedule_remove">cancel scheduled post?</string>

build.gradle

@@ -9,7 +9,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.2.0'
+        classpath 'com.android.tools.build:gradle:8.2.2'
     }
 }