Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC021: client_id can't be derived from request #269

Open
reinkrul opened this issue Dec 8, 2023 · 1 comment
Open

RFC021: client_id can't be derived from request #269

reinkrul opened this issue Dec 8, 2023 · 1 comment

Comments

@reinkrul
Copy link
Member

reinkrul commented Dec 8, 2023

client_id can't be simply derived from the credential subject, since there can be multiple VPs in vp_token and multiple credential subject in the VPs. In my opinion, client_id is passed by the client/RP with some form of authenticated, so we should derive it.

The current Nuts node implementation makes a best guess of the credential subject of the first presentation in vp_token, but should be adressed in the RFC.

@woutslakhorst
Copy link
Member

The current RFC says: all credentialSubject.ID values MUST be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants