fix(promo): promote/demote range + keybinds

[benlubas]

what it says on the tin. These were broken/removed a while ago. Presumably due to concealer changes but I'm not sure. Someone asked about bringing them back today, so here they are.

The re-indentation code in this module seems to struggle a little though. Not sure what's up with that.

[mtrajano]

Looks to be working fine for me. Tried indenting several nested lists with no problem, what issues did you run into re: the indentation?

[vhyrro]

@mtrajano the issue stems from e.g. paragraphs. It seems that the indentation is cumulative: with the following snippet:

* One
** Two
     content.

Doing a ranged promotion indents the paragraph twice as far:

** One
*** Two
              content.

This isn't the absolute end of the world, but would be nice to have fixed somehow 🤔

edit: wow, github rendering makes the indentation look really bad in the code block. it's less bad in a Norg buffer haha

[benlubas]

@mtrajano @vhyrro

Now this behaves itself a little better. There is still one behavior that might be unexpected. If you promote:

* heading
  Normal text

Normal text is correctly indented. But if you promote:

normal text
- list item

Then "normal text" is indented, while "list item" is promoted. However, this case:

- list

new paragraph
- new list

"new paragraph" is not indented.

---

I think this behavior is fine. It allows visual >/< to still work like normal in norg documents when you don't highlight anything promote-able. And if you only highlight the things you want to promote without extra paragraphs, there's no problem with it.

[mtrajano]

Changes make sense to make, there's just a random print statement there

[mtrajano]

This also feels internal to the indent module. Shouldn't have to pass it an indent, just a bufnr and a range/line number and it should be able to figure it out

[mtrajano]

can be part of module.private, not sure what the convention around this is

[benlubas]

I like this convention, vhyrro and I have gone back and forth on this in the past as well.

[mtrajano]

I would rename to reindent_line just to be consistent with the above, and rename the start_row to line

[vhyrro]

@benlubas the new behaviour is much better than what we had previously, so that sounds good enough for the time being. Running out of time today, but I'll revisit this PR tomorrow :)